Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rocTracer] Protect dependency on roctx64 #2502

Open
junliume opened this issue Nov 3, 2023 · 1 comment
Open

[rocTracer] Protect dependency on roctx64 #2502

junliume opened this issue Nov 3, 2023 · 1 comment

Comments

@junliume
Copy link
Collaborator

junliume commented Nov 3, 2023

Introduced by #2391

https://github.com/ROCmSoftwarePlatform/MIOpen/blob/19c6046d1a1d2ac7123fbeaf7775dd7a5749bfd3/src/CMakeLists.txt#L849

Maybe the line is better with

    find_library(LIBTX64 roctx64)
    if(LIBTX64)
        MESSAGE(STATUS "Libtx64: " ${LIBTX64})
        target_internal_library(MIOpen ${LIBTX64})
    endif()

There might be better design when rocTracer is not installed, I think we should protect the case somehow.

Other related issues: the NEEDED below needs to be explicitly set as dependencies for MIOpen package

➜  build git:(develop) ✗ objdump -x lib/libMIOpen.so | grep -A 15 "Dynamic Section"
Dynamic Section:
  RUNPATH              /opt/rocm/lib:/opt/rocm-5.7.0/lib::/opt/rocm/lib
  NEEDED               libamd_comgr.so.2
  NEEDED               librocblas.so.3
  NEEDED               libroctx64.so.4
  NEEDED               libamdhip64.so.5
  NEEDED               libstdc++.so.6
  NEEDED               libm.so.6
  NEEDED               libgcc_s.so.1
  NEEDED               libc.so.6
  NEEDED               ld-linux-x86-64.so.2
  SONAME               libMIOpen.so.1
  RELA                 0x00000000002710c0
  RELASZ               0x00000000006364f8
  RELAENT              0x0000000000000018
  RELACOUNT            0x000000000003c97b
@junliume
Copy link
Collaborator Author

junliume commented Nov 7, 2023

@atamazov @JehandadKhan could you take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants