Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded builds are broken #2763

Closed
atamazov opened this issue Feb 19, 2024 · 8 comments · Fixed by #3053
Closed

Embedded builds are broken #2763

atamazov opened this issue Feb 19, 2024 · 8 comments · Fixed by #3053

Comments

@atamazov
Copy link
Contributor

atamazov commented Feb 19, 2024

$ cmake ... -DMIOPEN_EMBED_DB='gfx906_60' ...
...
-- Embedding files
ERROR Unable to locate file /root/github/MLOpen1/build/embedded/share/miopen/db/gfx906_60.HIP.fdb.txt to embed
ERROR Unable to locate file /root/github/MLOpen1/build/embedded/share/miopen/db/gfx906_60.db to embed
-- Generating embedding library miopen_data
CMake Error at cmake/embed.cmake:64 (message):
  Symbols and objects dont match: 0 != 2
Call Stack (most recent call first):
  cmake/embed.cmake:148 (generate_embed_source)
  src/CMakeLists.txt:920 (add_embed_library)
...

❗ The implicit reason of the issue is that Fp32 Hip Debug Embedded Vega20 CI stage is disabled for 5 months due to #2395 (comment).


[Attribution] @junliume @JehandadKhan

@atamazov
Copy link
Contributor Author

Faulty commit is b9f6ef2, [HotFix] Fix DB install after #2347 (#2702).

@atamazov
Copy link
Contributor Author

/cc @apwojcik

@atamazov
Copy link
Contributor Author

The fix should include enabling at least one Embedded Smoke stage on CI (MI200 is fine).

@atamazov atamazov changed the title Embedded builds are broken. Embedded builds are broken Feb 19, 2024
@junliume
Copy link
Collaborator

Observed issues that the DB files under build/share/miopen/db/ are not generated without making a target. So with or without embedded config included in cmake line, the folder build/share/miopen/db/ does not contain findDB or perfDB, kDB.

unpack_db(${DB_BZIP_FILE})

@atamazov
Copy link
Contributor Author

@junliume @JehandadKhan @apwojcik I still recommend either fixing this or getting rid of the Embedded Build feature (but the latter does not make sense to me as we put substantial efforts into this feature).

@apwojcik
Copy link
Collaborator

apwojcik commented Mar 14, 2024

@atamazov @JehandadKhan @junliume @tperry-amd It is on my list, but it has to wait until I finish with PRs fixing MIOpen runtime bugs on Windows. Next, I will fix the embed build and submit PR for building dependencies directly from CMake.
The plan is to replace the content of embed.cmake from MIOpen with Embed.cmake from MIGraphX (as much as possible), which had been ported to support Windows resource files - the native technology for embedding data into binary files on Windows (i.e., executables, DLLs, data only libraries, etc.).

@apwojcik
Copy link
Collaborator

Unless it is urgent, let someone else take over the task and fix the embed build, and I will help.

@atamazov
Copy link
Contributor Author

@apwojcik It's Ok, I do not think this is urgent. Just want to make sure that eventually this issue will be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants