Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue]: Explicit specialization cannot have a storage class #1418

Closed
anjenner opened this issue Jul 25, 2024 · 3 comments
Closed

[Issue]: Explicit specialization cannot have a storage class #1418

anjenner opened this issue Jul 25, 2024 · 3 comments

Comments

@anjenner
Copy link

Problem Description

A recent clang change llvm/llvm-project#93873 revealed an issue in develop branch of composable_kernel:

In file included from composable_kernel/library/src/tensor_operation_instance/gpu/grouped_conv3d_fwd_bilinear/xdl/device_grouped_conv3d_fwd_xdl_bilinear_ndhwgc_gkzyxc_ndhwgk_f16_instance.cpp:4:
In file included from composable_kernel/library/include/ck/library/tensor_operation_instance/gpu/grouped_conv_fwd/device_grouped_conv_fwd_xdl_bilinear_instance.hpp:6:
In file included from composable_kernel/include/ck/tensor_operation/gpu/device/impl/device_grouped_conv_fwd_multiple_abd_xdl_cshuffle.hpp:21:
In file included from composable_kernel/include/ck/tensor_operation/gpu/grid/gridwise_gemm_multiple_d_xdl_cshuffle.hpp:12:
In file included from composable_kernel/include/ck/tensor_operation/gpu/block/blockwise_gemm_xdlops.hpp:9:
composable_kernel/include/ck/tensor_operation/gpu/warp/xdlops_gemm.hpp:654:5: error: explicit specialization cannot have a storage class [-Werror,-Wexplicit-specialization-storage-class]
654 | static constexpr auto GetMfma<double, 16, 16>()
| ^~~~~~

and many other instances. Presumably the correct fix is just to remove "static" from all these places.

Operating System

n/a

CPU

n/a

GPU

AMD Instinct MI100

Other

No response

ROCm Version

ROCm 6.0.0

ROCm Component

Composable Kernel

Steps to Reproduce

No response

(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support

No response

Additional Information

No response

@ppanchad-amd
Copy link

@anjenner Internal ticket has been created to fix this issue. Thanks!

@junliume
Copy link
Contributor

Static method in a template is not a good idea, but it should not be blocking/lethal either. If this is blocking your build, please consider using warning suppression first and we will fix it later.

@illsilin
Copy link
Collaborator

I fixed this issue: #1533

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants