-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OMPT Target Offload Support #411
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- generic tracing::get_clock_skew(...) function
- use github.com/ROCm/timemory instead of github.com/NERSC/timemory
- improved OMPT support
- new tmp_file::open member function (public) - new tmp_file::touch member function (private) - handle pid changing due to forking
- fix "unknown field type" error
- use new (generic) tracing::get_clock_skew(...) function
- fix warning regarding get_reserved_vector<bool>
- lib/omnitrace/library/ompt.cpp - new component::ompt - uses category_region - handle OMPT target offload buffer records
jrmadsen
added
bug fix
Fixes a bug
perfetto
Issue affects/involves perfetto features/capabilities
timemory
Issue affects/involves timemory features/capabilities
OMPT
OpenMP tools
submodule
Updates a git submodule
new feature
Introduces new feature
labels
Oct 24, 2024
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
This reverts commit 8bad7db.
Make sure the latest cmake is installed. Signed-off-by: David Galiffi <David.Galiffi@amd.com>
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
Need to install crb enable before installing texinfo
Installing dnf-command(config-manager) is required to enable CRB for rockylinux 9.0
Required to build Dyninst
Add "${OMP_TARGET_COMPILER_DIR}/llvm/lib" to the BUILD_RPATH. This path is common to new and old versions of ROCm
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
- fixes for openmp::get_enum_label - removed ignoring the first implicit task for non-main threads
jrmadsen
force-pushed
the
jomadsen/ompt-target-support
branch
from
October 30, 2024 07:34
479eeb0
to
ac2ea1f
Compare
- only update file maps once per-thread in codeptr_ra_resolver
jrmadsen
force-pushed
the
jomadsen/ompt-target-support
branch
from
October 30, 2024 07:37
ac2ea1f
to
cf9a58e
Compare
dgaliffiAMD
approved these changes
Oct 30, 2024
dgaliffiAMD
added a commit
to dgaliffiAMD/rocprofiler-systems
that referenced
this pull request
Oct 31, 2024
Ported from ROCm/omnitrace#411 Signed-off-by: David Galiffi <David.Galiffi@amd.com>
dgaliffiAMD
added a commit
to dgaliffiAMD/rocprofiler-systems
that referenced
this pull request
Oct 31, 2024
* Porting from ROCm/omnitrace#411 * Improve OMPT support * Add OpenMP target example to testing * Update Timemory submodule to use ROCm/Timemory rather than NERSC/Timemory Signed-off-by: David Galiffi <David.Galiffi@amd.com>
dgaliffiAMD
added a commit
to ROCm/rocprofiler-systems
that referenced
this pull request
Nov 5, 2024
- Fix for proto files not being viewable in Perfetto UI - Ported from ROCm/omnitrace#411 - Update Workflows - Use V47 trace_processor_shell for certain OS releases. - RedHat 8, SUSE 15.5, and Ubuntu 20.04 are no longer compatible with the latest trace_processor_shell. - Incompatible version of GLIBC. - Remove notes about Perfetto workaround in documentation. --------- Signed-off-by: David Galiffi <David.Galiffi@amd.com>
dgaliffiAMD
added a commit
to dgaliffiAMD/rocprofiler-systems
that referenced
this pull request
Nov 6, 2024
* Porting from ROCm/omnitrace#411 * Improve OMPT support * Add OpenMP target example to testing * Update Timemory submodule to use ROCm/Timemory rather than NERSC/Timemory Signed-off-by: David Galiffi <David.Galiffi@amd.com>
dgaliffiAMD
added a commit
to dgaliffiAMD/rocprofiler-systems
that referenced
this pull request
Nov 6, 2024
- Fix for proto files not being viewable in Perfetto UI - Ported from ROCm/omnitrace#411 - Update Workflows - Use V47 trace_processor_shell for certain OS releases. - RedHat 8, SUSE 15.5, and Ubuntu 20.04 are no longer compatible with the latest trace_processor_shell. - Incompatible version of GLIBC. - Remove notes about Perfetto workaround in documentation. --------- Signed-off-by: David Galiffi <David.Galiffi@amd.com>
dgaliffiAMD
added a commit
to ROCm/rocprofiler-systems
that referenced
this pull request
Nov 7, 2024
- Porting from ROCm/omnitrace#411 - Improve OMPT support - Add OpenMP target example to testing - Update Timemory submodule to use ROCm/Timemory rather than NERSC/Timemory - Update `actions/upload-artifacts` to v4 - Standardize the `cmake_minimum_required` to 3.18.4 across workflows, project, and examples - Updated Ubuntu 20.04 workflows
dgaliffiAMD
added a commit
to ROCm/rocprofiler-systems
that referenced
this pull request
Nov 8, 2024
- Porting from ROCm/omnitrace#411 - Improve OMPT support - Add OpenMP target example to testing - Update Timemory submodule to use ROCm/Timemory rather than NERSC/Timemory - Update `actions/upload-artifacts` to v4 - Standardize the `cmake_minimum_required` to 3.18.4 across workflows, project, and examples - Updated Ubuntu 20.04 workflows
dgaliffiAMD
added a commit
to ROCm/rocprofiler-systems
that referenced
this pull request
Nov 18, 2024
- Fix for proto files not being viewable in Perfetto UI - Ported from ROCm/omnitrace#411 - Update Workflows - Use V47 trace_processor_shell for certain OS releases. - RedHat 8, SUSE 15.5, and Ubuntu 20.04 are no longer compatible with the latest trace_processor_shell. - Incompatible version of GLIBC. - Remove notes about Perfetto workaround in documentation. --------- Signed-off-by: David Galiffi <David.Galiffi@amd.com>
dgaliffiAMD
added a commit
to ROCm/rocprofiler-systems
that referenced
this pull request
Nov 18, 2024
- Porting from ROCm/omnitrace#411 - Improve OMPT support - Add OpenMP target example to testing - Update Timemory submodule to use ROCm/Timemory rather than NERSC/Timemory - Update `actions/upload-artifacts` to v4 - Standardize the `cmake_minimum_required` to 3.18.4 across workflows, project, and examples - Updated Ubuntu 20.04 workflows
dgaliffiAMD
added a commit
to ROCm/rocprofiler-systems
that referenced
this pull request
Nov 20, 2024
- Porting from ROCm/omnitrace#411 - Improve OMPT support - Add OpenMP target example to testing - Update Timemory submodule to use ROCm/Timemory rather than NERSC/Timemory - Update `actions/upload-artifacts` to v4 - Standardize the `cmake_minimum_required` to 3.18.4 across workflows, project, and examples - Updated Ubuntu 20.04 workflows
dgaliffiAMD
added a commit
to dgaliffiAMD/rocprofiler-systems
that referenced
this pull request
Nov 20, 2024
- Fix for proto files not being viewable in Perfetto UI - Ported from ROCm/omnitrace#411 - Update Workflows - Use V47 trace_processor_shell for certain OS releases. - RedHat 8, SUSE 15.5, and Ubuntu 20.04 are no longer compatible with the latest trace_processor_shell. - Incompatible version of GLIBC. - Remove notes about Perfetto workaround in documentation. --------- Signed-off-by: David Galiffi <David.Galiffi@amd.com>
dgaliffiAMD
added a commit
to ROCm/rocprofiler-systems
that referenced
this pull request
Nov 20, 2024
- Porting from ROCm/omnitrace#411 - Improve OMPT support - Add OpenMP target example to testing - Update Timemory submodule to use ROCm/Timemory rather than NERSC/Timemory - Standardize the `cmake_minimum_required` to 3.18.4 across workflows, project, and examples Signed-off-by: David Galiffi <David.Galiffi@amd.com>
dgaliffiAMD
added a commit
to dgaliffiAMD/rocprofiler-systems
that referenced
this pull request
Nov 20, 2024
- Fix for proto files not being viewable in Perfetto UI - Ported from ROCm/omnitrace#411 - Update Workflows - Use V47 trace_processor_shell for certain OS releases. - RedHat 8, SUSE 15.5, and Ubuntu 20.04 are no longer compatible with the latest trace_processor_shell. - Incompatible version of GLIBC. - Remove notes about Perfetto workaround in documentation. --------- Signed-off-by: David Galiffi <David.Galiffi@amd.com>
ashuverm
pushed a commit
to ROCm/rocprofiler-systems
that referenced
this pull request
Nov 22, 2024
- Porting from ROCm/omnitrace#411 - Improve OMPT support - Add OpenMP target example to testing - Update Timemory submodule to use ROCm/Timemory rather than NERSC/Timemory - Standardize the `cmake_minimum_required` to 3.18.4 across workflows, project, and examples Signed-off-by: David Galiffi <David.Galiffi@amd.com>
ashuverm
pushed a commit
to ROCm/rocprofiler-systems
that referenced
this pull request
Nov 22, 2024
- Fix for proto files not being viewable in Perfetto UI - Ported from ROCm/omnitrace#411 - Update Workflows - Use V47 trace_processor_shell for certain OS releases. - RedHat 8, SUSE 15.5, and Ubuntu 20.04 are no longer compatible with the latest trace_processor_shell. - Incompatible version of GLIBC. - Remove notes about Perfetto workaround in documentation. --------- Signed-off-by: David Galiffi <David.Galiffi@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes OMPT support for OpenMP Target Offload applications