diff --git a/CMakeLists.txt b/CMakeLists.txt index b779d4ca..f3f879f7 100755 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -14,6 +14,10 @@ endif() ## Include common cmake modules include(utils) +if (NOT DEFINED CPACK_RESOURCE_FILE_LICENSE) + set(CPACK_RESOURCE_FILE_LICENSE "${CMAKE_CURRENT_SOURCE_DIR}/License.txt") +endif() + set(ROCM_SMI "rocm_smi") set(ROCM_SMI_COMPONENT "lib${ROCM_SMI}") set(ROCM_SMI_TARGET "${ROCM_SMI}64") @@ -96,7 +100,7 @@ endif () # Use this instead of above for 32 bit # set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -m32") -if ("${CMAKE_BUILD_TYPE}" STREQUAL Release) +if ("${CMAKE_BUILD_TYPE}" MATCHES Rel.*) set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -O2") else () set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -ggdb -O0 -DDEBUG") @@ -170,7 +174,9 @@ install(FILES install(EXPORT rocm_smiTargets DESTINATION "${ROCM_SMI}/lib/cmake" COMPONENT dev) - +#License file +set(CPACK_RPM_PACKAGE_LICENSE "NCSA") +install( FILES ${CPACK_RESOURCE_FILE_LICENSE} DESTINATION share/doc/smi-lib RENAME LICENSE.txt) ########################### # Packaging directives diff --git a/src/rocm_smi_device.cc b/src/rocm_smi_device.cc index 51e67822..a80fcd31 100755 --- a/src/rocm_smi_device.cc +++ b/src/rocm_smi_device.cc @@ -630,7 +630,7 @@ int Device::writeDevInfoStr(DevInfoTypes type, std::string valStr) { ret = RSMI_STATUS_NOT_SUPPORTED; } fs.close(); - + return ret; } @@ -742,7 +742,8 @@ int Device::readDevInfoMultiLineStr(DevInfoTypes type, return 0; } // Remove any *trailing* empty (whitespace) lines - while (retVec->back().find_first_not_of(" \t\n\v\f\r") == std::string::npos) { + while (retVec->size() != 0 && + retVec->back().find_first_not_of(" \t\n\v\f\r") == std::string::npos) { retVec->pop_back(); } return 0;