Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue]: RPP Core dependency - Update Compiler and CXX Flags #490

Open
kiritigowda opened this issue Dec 14, 2024 · 3 comments
Open

[Issue]: RPP Core dependency - Update Compiler and CXX Flags #490

kiritigowda opened this issue Dec 14, 2024 · 3 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@kiritigowda
Copy link
Collaborator

Problem Description

  • Readme - FileSystem is not added to the list of dependencies
  • CMakeLists - Find FileSystem and turn off features if not found

Operating System

ALL

CPU

ALL

GPU

AMD Instinct MI300

Other

No response

ROCm Version

ROCm 6.0.0

ROCm Component

rpp

Steps to Reproduce

No response

(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support

No response

Additional Information

No response

@kiritigowda kiritigowda added the bug Something isn't working label Dec 14, 2024
@kiritigowda
Copy link
Collaborator Author

kiritigowda commented Dec 16, 2024

@hansely with the filesystem should the link library be added if experimental only - stdc++fs?

RPP adding here -

set(LINK_LIBRARY_LIST ${LINK_LIBRARY_LIST} stdc++fs)

Should we first find filesystem and then link if experimental?

@hansely
Copy link
Contributor

hansely commented Dec 16, 2024

stdc++fs linking is only needed for older compiler.
Newer compilers (GCC >= 9, Clang >= 9, MSVC >= 2017) doesn't require linking.

Macros could be used to check if filesystem is available.
Refer to
https://github.com/ROCm/MIVisionX/blob/develop/utilities/mv_deploy/mv_compile.cpp#L34

@kiritigowda kiritigowda changed the title [Issue]: RPP Core Missing dependency - Find FileSystem [Issue]: RPP Core dependency - Update Compiler and CXX Flags Dec 17, 2024
@kiritigowda
Copy link
Collaborator Author

@hansely please create a PR to update documentation and any required docs to close this issue

@kiritigowda kiritigowda added the enhancement New feature or request label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants