Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "maybe" VASL logic #24

Open
ROMaster2 opened this issue Jan 3, 2019 · 2 comments
Open

Implement "maybe" VASL logic #24

ROMaster2 opened this issue Jan 3, 2019 · 2 comments

Comments

@ROMaster2
Copy link
Owner

Pausing/Splitting/Starting should happen when you think they happen. "Maybe" logic triggers those events, but undoes them if it turned out to be incorrect.

@kenman345
Copy link
Contributor

So, would maybe logic include some sort of popup asking for a few seconds (maybe 10-20 by default but also configurable), if that was supposed to split, and if you confirm it, then it uses the original time it expected for the split to happen.

Maybe logic could also include if it thinks it should split, but within a certain window of time it gets a higher confidence level to split, would ignore the first time, while also working with the prompt I suggested above.

@ROMaster2
Copy link
Owner Author

Ideally it should be scripted to tell the "maybe" if it's correct or incorrect at a later time.
Here's a example that I believe would work, but is far from elegant:

split
{
    if (features["foo"] > 70.0)
    {
        // Current time plus 10 seconds
        vars.lastSplitTime = timer.CurrentTime.RealTime.Value.Add(new TimeSpan(0,0,10);
        return true;
    }
}

undo
{
    return features["bar"] > 80.0 && timer.CurrentTime.RealTime.Value < vars.lastSplitTime;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants