Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation support #4

Open
ROMaster2 opened this issue Dec 20, 2018 · 6 comments
Open

Add translation support #4

ROMaster2 opened this issue Dec 20, 2018 · 6 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@ROMaster2
Copy link
Owner

Not super sure how to go about doing that.

@ROMaster2 ROMaster2 added enhancement New feature or request help wanted Extra attention is needed labels Dec 20, 2018
@ROMaster2 ROMaster2 added this to the 1.5 milestone Dec 20, 2018
@ROMaster2 ROMaster2 self-assigned this Dec 20, 2018
@kenman345
Copy link
Contributor

So, I think we basically just create a helper class that will take the configured language and return us the translation for that if we have it, otherwise, return english. Usually this might be based on an xml file with all the different versions, or a JSON file for each language.

Then we need to go into all the places we have hardcoded words for things and replace it with calls to that helper class.

@kenman345
Copy link
Contributor

I am not fluent in any language besides english but I could at least help with getting the helper class put together.

@kenman345
Copy link
Contributor

will logs also be in another language? It might be a bit weird. If anything I say, always include english at the end of logs, so that we can get the information needed to help with errors or bugs that are popping up there.

@ROMaster2
Copy link
Owner Author

Errors should have codes attached to them to identify what it is regardless of language.

Haven't made anything like a Helper class for translations before. I don't think a separate XML/JSON would be necessary, especially since AFAIK no other component does that for translations. It can be added inline.

@kenman345
Copy link
Contributor

Using a separate XML/JSON would mean people can easily add in translations without a rebuild and help build out the language.

But we can keep this on the backburner as things progress it can always be added

@kenman345
Copy link
Contributor

first things first, where will the setting exist to change the language? We can put together a branch with that option in it and then work on the structure needed to have dynamic language, and find people to help translate things properly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants