Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Display Name field needs to be blank #3247

Closed
michaelperino opened this issue Dec 4, 2021 · 7 comments
Closed

[Bug]: Display Name field needs to be blank #3247

michaelperino opened this issue Dec 4, 2021 · 7 comments
Assignees
Labels
bug tested This issue has been QA tested by someone other than the developer.

Comments

@michaelperino
Copy link
Contributor

Describe the Bug

Creating a new map has the display name "Grasslands" by default instead of being blank.

To Reproduce

  1. Map new map
  2. Read Display Name field

Expected Behaviour

Display name field blank when not in use

Screenshots

image

MapTool Info

Version 1.11.2

Desktop

All

Additional Context

No response

@Phergus
Copy link
Contributor

Phergus commented Dec 4, 2021

Why does it need to be blank?

@michaelperino
Copy link
Contributor Author

michaelperino commented Dec 5, 2021

Makes it more obvious that people don't need to change it if they don't plan to use the feature. Also, if you set the name to something else on creation instead of renaming it later, the display name will be grasslands with the GM Name being different.

@Phergus
Copy link
Contributor

Phergus commented Dec 5, 2021

Also, if you set the name to something else on creation instead of renaming it later, the display name will be grasslands with the GM Name being different.

Actually if you set the GM name and don't touch the Display Name field it gets set to the GM name.

@FullBleed
Copy link

FullBleed commented Dec 6, 2021

Actually if you set the GM name and don't touch the Display Name field it gets set to the GM name.

That's good. But it doesn't make much sense for the Display Name to say "Grasslands" if it's going to take on the (GM) Name. Better to have it blank in that case, imo. Would be even better if there was a way to have it mirror the "Name" field entry real-time if blank, but not if it has has any kind of manual input. Not sure that's possible though.

@Phergus
Copy link
Contributor

Phergus commented Dec 6, 2021

The Display Name could be updated to match when the GM Name is changed to get the visual confirmation of the change.

@bubblobill
Copy link
Collaborator

Not a fan of the Display Name. I agree that it should be blank unless specifically set

@Phergus Phergus moved this to Todo in MapTool 1.13.0 Sep 18, 2022
@Phergus Phergus moved this from Todo to In Progress in MapTool 1.13.0 Dec 23, 2022
@Phergus Phergus moved this from In Progress to Needs Testing in MapTool 1.13.0 Jan 1, 2023
@Phergus Phergus added the tested This issue has been QA tested by someone other than the developer. label Feb 20, 2023
@Phergus
Copy link
Contributor

Phergus commented Feb 20, 2023

Display Name is now blank.

@Phergus Phergus closed this as completed Feb 20, 2023
@github-project-automation github-project-automation bot moved this from Needs Testing to Merged in MapTool 1.13.0 Feb 20, 2023
@Phergus Phergus moved this from Merged to Done in MapTool 1.13.0 Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug tested This issue has been QA tested by someone other than the developer.
Projects
Status: Done
Development

No branches or pull requests

5 participants