[Bug]: Java NPE Prints In Chat Upon All On-Map Mouse Clicks

[StowGnar]

Describe the Bug

Every mouseclick in the map window (though not in any of the dockable windows, I believe) caused this error message to be printed out in plaintext in the Chat:

java.lang.NullPointerException: Cannot invoke "java.awt.Rectangle.getX()" because the return value of "com.jidesoft.docking.DockContext.getUndockedBounds()" is null error executing expression IFS = json.get(getInfo("client"),"isFullScreen").
Error trace : buttonHandler@Lib:OnTokenMove <<< macroLink

I was told "That error is a problem with the Java code not checking for a null return value, not an MTscript issue." by Azhrei. Unfortunately, I ended up going to bed and restarting my PC before writing this report, and the error now does not persist upon having reconnected. My apologies for losing a more preserved copy of the error and the steps to reproduce it. I can say this did occur after running a series of Bag of Tricks macros, if I recall correctly.

To Reproduce

Unknown, other than Bag of Tricks and its onTokenMove's buttonHandler macro being involved (obviously). However, it sounded like a more universal issue than just BoT by the way Azhrei described, so this is probably only one way of reaching the same NPE.

Expected Behaviour

Click anywhere and only receive relevant data/feedback from those clicks.

Screenshots

I foolishly did not screenshot the NPE in chat, only copied the text as above.

MapTool Info

1.11.4

Desktop

Windows 10

Additional Context

Two different client instances (one player, one GM) were open and connected to remote server on a VPS. NPE started being printed to chat after local GM instance ran series of BoT macros.

[kwvanderlinde]

I believe I have a consistent way to reproduce this for testing purposes:

1. Run this macro to open a frame: [r, frame5("3316 test", "temporary=0"): { }]
2. Dock the frame somewhere
3. Window > Restore Layout
4. Run [r: getInfo("client")] in chat

At this point, MapTool remembers that the frame was docked and will automatically dock it whenever it is reopened. So if you close and reopen MapTool, you'll notice first that [r: getInfo("client")] starts to work. But once you reopen the frame as in step (1), it will start to fail again.

[Pmofmalasia]

The method given does not reproduce the bug for me in 1.13.2 - though I have not tested 1.12.x to see if it worked for me there.

[kwvanderlinde]

Thanks @Pmofmalasia! That should be a consistent reproduction, so I'll consider that independent validation.