Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Poor contrast for text in chat and other (non-WebView) HTML contexts with some themes #3589

Closed
Irarara opened this issue Sep 4, 2022 · 1 comment · Fixed by #3590
Assignees
Labels
bug tested This issue has been QA tested by someone other than the developer.

Comments

@Irarara
Copy link
Contributor

Irarara commented Sep 4, 2022

Describe the Bug

Themes seem to set the default text color for Swing HTML documents, and with dark themes this results in difficult to read text when set against light backgrounds (such as with the chat panel or HTML frames, etc.).

To Reproduce

  1. Set a dark theme (Such as Arc Dark)
  2. Enter a message in the chat and observe how the user name appears in a very light color
  3. Enter [frame("test"),code: { test }] in the chat and see how the text color in the frame is the same

Expected Behaviour

The default text color should be black for these parts of the UI.

Screenshots

No response

MapTool Info

develop branch

Desktop

Windows 10

Additional Context

No response

@Irarara Irarara added the bug label Sep 4, 2022
@Phergus Phergus added the tested This issue has been QA tested by someone other than the developer. label Sep 5, 2022
@Phergus
Copy link
Contributor

Phergus commented Sep 5, 2022

Tested. Chat text and default text in dialogs/frames is now black in all themes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug tested This issue has been QA tested by someone other than the developer.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants