Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactoring]: Dicelib should be merged into MapTool Repository #3999

Closed
cwisniew opened this issue Apr 25, 2023 · 0 comments · Fixed by #4000
Closed

[Refactoring]: Dicelib should be merged into MapTool Repository #3999

cwisniew opened this issue Apr 25, 2023 · 0 comments · Fixed by #4000
Assignees

Comments

@cwisniew
Copy link
Member

Describe the problem

Dicelib is so intrinsically linked MapTool that it's unlikely anything else will ever use it -- it even requires the parser project to work. On top of this, it is harder for contributors to contribute new dice rolls as it requires performing a juggling act to ensure that you can test your changes locally before submitting two PRs to two different repositories.

The improvement you'd like to see

Merge the dicelib into the MapTool repository

Expected Benefits

Less friction for those that want to add new dice rolls as right now its a hassle

Additional Context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant