Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: A way to disable soft FoW / visibility in night maps #4232

Open
kwvanderlinde opened this issue Aug 2, 2023 · 5 comments
Open
Labels
feature Adding functionality that adds value

Comments

@kwvanderlinde
Copy link
Collaborator

kwvanderlinde commented Aug 2, 2023

Describe the Problem

I find I don't really need / care about soft FoW in my games, and it sometimes causes confusion as players don't always see the tokens I expect. At the same time, we like playing on night maps, with lights, sights, and hard FoW being part of the experience. But right now, I can only disable soft FoW by setting vision to "Off", which also makes the map behave like a day map.

The Solution you'd like

I would like to split the map vision option into two separate concepts (names TBD):

  • Visibility: a toggle that determines whether to render soft FoW, hide tokens out of line-of-sight, etc. I.e., controls the things that are currently disabled when switching from "Day" to "Off".
  • Lighting: selection of "Day" or "Night" that determines whether lights (personal or otherwise) are required to illuminate areas, or whether the entire vision range is considered illuminated.

Alternatives that you've considered.

No response

Additional Context

This is a simpler version of #3822 that just focuses on separating the "Off" functionality from the others.

@kwvanderlinde kwvanderlinde added the feature Adding functionality that adds value label Aug 2, 2023
@FullBleed
Copy link

Would just having the ability to toggle Soft Fog on/off achieve what you want?

@kwvanderlinde
Copy link
Collaborator Author

kwvanderlinde commented Aug 15, 2023

That's essentially what the Visibility toggle is meant to be (I've now updated the description to call out soft FoW specifically). The various behaviours there are collectively what "soft FoW" is.

I guess calling it the Soft FoW toggle would make more sense in that case ...

@kwvanderlinde
Copy link
Collaborator Author

There is one more behaviour of the Vision setting that came up on Discord which I was surprised to find out about (though I should have known considering the implementation). When Vision is set to "Off", the server setting of Individual FoW is kind of ignored (though not totally): any fog exposure becomes global to the map in addition to being exposed for each token.

This is a behaviour I would not want controlled by the new Visibility / Soft FoW options, and certainly not by the new Lighting option. Actually, I would rather the behaviour didn't exist, but to support existing use cases I will instead propose that it be made a third new map setting, a toggle along the lines of Always Expose FoW Globally.

@FullBleed
Copy link

It feels like the current behaviour is kind of a bug... and I think I'd find the "Always Expose FoW Globally" toggle to be confusing (especially for new users trying to understand how everything interacts.)

Would an "Always Expose FoW Globally" toggle, essentially, be an Individual FoW toggle?

@kwvanderlinde
Copy link
Collaborator Author

It feels like the current behaviour is kind of a bug...

I would agree. Or rather I should say I don't think the current behaviour is desirable. After digging into the history a bit, it's clear the choice was deliberate for supporting maps that are just meant for temporarily parking tokens (see this forum thread, and especially this post). That use case is fine IMO, I would just rather it be called out as its own thing or be somehow incorporated into the fog settings instead of being attached to the otherwise unrelated Vision settings.

and I think I'd find the "Always Expose FoW Globally" toggle to be confusing (especially for new users trying to understand how everything interacts.)

I won't argue with that 🙂 But as mentioned above, there is a use case here, so some option for it is necessary. Of course it doesn't at all have to look like what I suggested, I'm sure there's a much more intuitive alternative.

Would an "Always Expose FoW Globally" toggle, essentially, be an Individual FoW toggle?

I think it could be, but depends how attached we are to the details of the current behaviour. Technically the current behaviour is that Vision=Off can act like Individual FoW and Global FoW are both enabled (assuming the Individual FoW server setting is applied). That means it could have an impact if the map/server settings change over time, though any reliance on that seems like quite an edge case to me.

@kwvanderlinde kwvanderlinde changed the title [Feature]: Disable soft FoW / visibility in night maps [Feature]: A way to disable soft FoW / visibility in night maps Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding functionality that adds value
Projects
None yet
Development

No branches or pull requests

2 participants