Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selling and buying X should validate correctly they are between unsigned short boundaries #67

Closed
lmsv-mx123 opened this issue Jan 15, 2021 · 0 comments · Fixed by #68
Closed
Labels
bug Something isn't working

Comments

@lmsv-mx123
Copy link
Member

lmsv-mx123 commented Jan 15, 2021

When Jagex placed the sell and buy x on store probably they thought was sent over as integer or an oversight of them (likely). Anyways currently is Integer.parseInt(input) and should be more like type of Short.parseUnsignedShort(input), that can be simulated that if the input > 65535 to throw NumberFormatException, else return the parsed num

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant