Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to flexibly specify weights #33

Closed
erika-redding opened this issue Jan 5, 2024 · 2 comments · Fixed by #75
Closed

Allow user to flexibly specify weights #33

erika-redding opened this issue Jan 5, 2024 · 2 comments · Fixed by #75
Assignees
Milestone

Comments

@erika-redding
Copy link
Collaborator

No description provided.

@ashleyasmus
Copy link
Collaborator

Might be good to use SANDAG weighted data as a test case. It has like six different weights ! !

@ashleyasmus
Copy link
Collaborator

I was looking into this, and it seems to all stem from the hard coded 'id' and 'weight' column names in hts_get_keycols. cursed! We should allow the user to specify the wtname, the idname ~ somewhere in prep data (??) and then carry that all the way through.

unfortunately hts_get_keycols is called by many other functions, which are in turn called by many other fucntions, inside the family of 'prep data' stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants