Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[🐛BUG] InterestExtractorNetwork of DIEN lacks a dense layer #821

Closed
KinvenW opened this issue May 5, 2021 · 2 comments
Closed

[🐛BUG] InterestExtractorNetwork of DIEN lacks a dense layer #821

KinvenW opened this issue May 5, 2021 · 2 comments
Assignees
@guijiql
Labels
bug Something isn't working

Comments

@KinvenW
Copy link

KinvenW commented May 5, 2021

InterestExtractorNetwork contains a auxiliary_net to calculate click_prop and noclick_prop so as to calculae auxiliary loss, however, auxiliary_net is a MLPLayers which output dim != 1, I thought we should add a output layer after auxiliary_net to transform dimension [output_dim of auxiliary_net → 1]
@KinvenW KinvenW added the bug Something isn't working label May 5, 2021
@guijiql
Copy link
Contributor

guijiql commented May 6, 2021

Oh, sorry. It's my negligence. I' ll fix it soon. Thank for your reminding!

@2017pxy
Copy link
Member

2017pxy commented May 7, 2021

@KinvenW Hi, the bug has been fixed in #824, thanks for your correction.

@2017pxy 2017pxy closed this as completed Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guijiql guijiql

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@2017pxy @KinvenW @guijiql @Sherry-XLL