Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pagerank algorithm #1653

Merged
merged 1 commit into from
Oct 26, 2017
Merged

Fix pagerank algorithm #1653

merged 1 commit into from
Oct 26, 2017

Conversation

xelez
Copy link
Contributor

@xelez xelez commented Oct 25, 2017

fixes #805

  • added a regression test for summarization.keywords()
  • handled case with graph smaller than 3 nodes
  • removed TODO about complex eigenvectors
  • added more comments

Comments are welcome =)

 * added a regression test for summarization.keywords()
 * handled case with graph smaller than 3 nodes
 * removed TODO about complex eigenvectors
 * added more comments
@xelez
Copy link
Contributor Author

xelez commented Oct 26, 2017

Em, it seems that failing test doesn't depend on modified code at all.

@menshikh-iv
Copy link
Contributor

@xelez you are right, we have many deterministic tests :( I re-run CI for you.

@menshikh-iv
Copy link
Contributor

Congratz with first PR @xelez, good job:+1:

@menshikh-iv menshikh-iv merged commit 00192a8 into piskvorky:develop Oct 26, 2017
horpto pushed a commit to horpto/gensim that referenced this pull request Oct 28, 2017
* added a regression test for summarization.keywords()
 * handled case with graph smaller than 3 nodes
 * removed TODO about complex eigenvectors
 * added more comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while summarizing text
2 participants