Fix _is_single from Phrases for case when corpus is numpy array of tokens
#1987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menshikh-iv
suggested changes
Mar 20, 2018
| @@ -118,7 +118,7 @@ def _is_single(obj): | |||
| if isinstance(peek, string_types): | |||
| # It's a document, return the iterator | |||
| return True, obj_iter | |||
| if temp_iter == obj: | |||
| if temp_iter is obj: | |||
There was a problem hiding this comment.
Need to add a clear test for the case when this doesn't work correctly without this fix (and now it works).
Also, return mode of file please (755 -> 644).
menshikh-iv
changed the title
_is_single from Phrases for case when corpus is numpy array of tokens
|
Good catch @rmalouf, congratz with the first contribution 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transforming a corpus using
Phraser[]fails with:if the corpus is a numpy array, a pandas Series, or anything else that defaults to element-wise comparison.
The problem is this check here:
A simple fix is replacing
==withis