Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linear decay for learning rate in Doc2Vec.infer_vector. Fix #2061 #2063

Merged
merged 2 commits into from
Jun 20, 2018

Conversation

umangv
Copy link
Contributor

@umangv umangv commented May 25, 2018

This would fix issue #2061

@gojomo
Copy link
Collaborator

gojomo commented Jun 11, 2018

Looks good to me! This should be a high-priority fix. @menshikh-iv

@gojomo gojomo added bug Issue described a bug performance Issue related to performance (in HW meaning) labels Jun 18, 2018
@gojomo gojomo requested review from piskvorky and menshikh-iv June 18, 2018 18:04
@piskvorky
Copy link
Owner

piskvorky commented Jun 18, 2018

Any updates needed to our tutorials / docs, after this change?

@gojomo
Copy link
Collaborator

gojomo commented Jun 18, 2018

This is always how it should have worked. If tests are passing (and they are), I'd expect any uses of inference in tutorials to just start working better – maybe a little, maybe a lot. (I wouldn't make merging this tiny fix dependent on refreshing all those result-cells.)

@menshikh-iv menshikh-iv changed the title Linear decay for learning rate in infer_vector Fix linear decay for learning rate in Doc2Vec.infer_vector. Fix #2061 Jun 20, 2018
@menshikh-iv
Copy link
Contributor

Thanks @umangv, congratz with the first contribution 🥇

@menshikh-iv menshikh-iv merged commit 8715c00 into piskvorky:develop Jun 20, 2018
@piskvorky
Copy link
Owner

piskvorky commented Jun 20, 2018

@gojomo @umangv can you draft a summary of this PR for the release changelog? From the user perspective (not internal dev): who is affected, in what way, what should they do about it (if anything).

High-level; a few short, clear sentences.

@umangv
Copy link
Contributor Author

umangv commented Jun 20, 2018

This change fixes a bug in Doc2Vec.infer_vector that caused the learning rate to decay very fast. With this change, infer_vectors method should return more consistent document vectors and require far fewer steps to converge, especially for short documents.

@umangv umangv deleted the umangv-learnrate branch June 20, 2018 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue described a bug performance Issue related to performance (in HW meaning)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants