Refactor BM25
#2275
Merged
Refactor BM25
#2275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
horpto
commented
Nov 22, 2018
horpto
commented
- remove unnecessary attributes
- move calculation of average_idf in _initialize
- more readable names
piskvorky
reviewed
Nov 23, 2018
gensim/summarization/bm25.py
Outdated
| idf_sum += idf | ||
| if idf < 0: | ||
| negative_idfs.append(word) | ||
| self.average_idf = idf_sum / len(self.idf) |
There was a problem hiding this comment.
Use float (or explicitly cast to float). Both to avoid potential Python errors in integer vs float division, as well as to make the intent clear to readers of the code.
| nd[word] += 1 | ||
|
|
||
| # collect idf sum to calculate an average idf for epsilon value | ||
| idf_sum = 0 |
There was a problem hiding this comment.
Safer to use float (or explicitly cast to float below).
Both to avoid potential Python errors in integer vs float division in future refactorings, as well as (mainly) to make the intent clear to readers.
There was a problem hiding this comment.
oh, yes. you're right. Damn python2.
- remove unnecessary attributes - move calculation of average_idf in _initialize - more readable names
horpto
force-pushed
the
refactor-bm25
branch
from
d2f2311 to
a1875c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.