Fix infinite diff in LdaModel.do_mstep
#2344
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix partially #416
Fix partially #2051
This PR solves infinite diff in output. It works for me. This caused by a big negative values in
self.state.sstate
and narrow dtype of values. I try to solve only this bug.self.expElogbeta
can contain zeros anyway. That can be solved by pointing a more wide dtype, for examplenp.float64
. I don't increase dtype of self.expElogbeta as I know there is a drawback between memory consumption/file sizes/sent bytes and precision. User should be smart enough and choose wisely himself.