Fix misleading Doc2Vec.docvecs comment #2472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing doc-comment was confused & misleading, implying `Doc2Vec` handles word-senses by giving single word tokens different word-vectors in different contexts. (See <https://stackoverflow.com/questions/55939511/word-vectors-from-a-whole-doc2vec-model-vs-word-vectors-from-a-particular-docum/55941468#55941468> for an example confused user.) `Doc2Vec` doesn't do that, so this changes the comment to be matter-of-fact about accessing vectors via `.docvecs`.
|
Looks like there's a trailing whitespace somewhere, and it's causing flake8 to choke. Can you please have a look and fix? |
|
There are still problems with spaces that fail the flake8 linter. Please have a look here for details. |
|
I think it's fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing doc-comment was confused & misleading, implying
Doc2Vechandles word-senses by giving single word tokens different word-vectors in different contexts. (See https://stackoverflow.com/questions/55939511/word-vectors-from-a-whole-doc2vec-model-vs-word-vectors-from-a-particular-docum/55941468#55941468 for an example confused user.)Doc2Vecdoesn't do that, so this changes the comment to be matter-of-fact about accessing vectors via.docvecs.