Add build_vocab to poincare model #2505
Conversation
|
Add issue #2514 😃 |
|
@piskvorky Hi, please assign some reviewer |
|
We're busy finishing up a large "Gensim docs" project, but @mpenkov will get to your PR eventually. Thanks for your patience @koiizukag. |
gensim/models/poincare.py
Outdated
|
|
||
| def _load_relations(self): | ||
| def build_vocab(self, relations=None, update=False): |
There was a problem hiding this comment.
You've made this a public method, so it needs a good docstring. Please look at other docstrings in the code for examples on how to write a good one.
add doc
…kag/gensim into add-build_vocab-to-poincare_model
gensim/models/poincare.py
Outdated
| relations : list of tuples | ||
| List of tuples of positive examples of the form (node_1_index, node_2_index). | ||
| update : bool | ||
| If true, the new nodes in `relations` will be added to model's vocab. |
There was a problem hiding this comment.
But relations doesn't contain nodes. Its description above says it contains "node indexes" (btw where does the user find those?).
Also, what happens if False (the default)?
There was a problem hiding this comment.
I modified the description of relations using init description.
But relations doesn't contain nodes. Its description above says it contains "node indexes" (btw where does the user find those?).
If update=False, the embeddings are initialized by random values.
(It means that the trained embeddings are cleaned.)
Also, what happens if False (the default)?
There was a problem hiding this comment.
OK, I don't really understand that, but that information should appear in the documentation.
There was a problem hiding this comment.
I added update=False description in build_vocab 👍
Co-Authored-By: Michael Penkov <m@penkov.dev>
Co-Authored-By: Michael Penkov <m@penkov.dev>
Co-Authored-By: Michael Penkov <m@penkov.dev>
Co-Authored-By: Michael Penkov <m@penkov.dev>
Co-Authored-By: Michael Penkov <m@penkov.dev>
Co-Authored-By: Michael Penkov <m@penkov.dev>
Co-Authored-By: Michael Penkov <m@penkov.dev>
|
Thanks for your modification. LGTM |
minor update
|
@mpenkov Is there anything to be done next❓ |
|
@piskvorky I think this PR is ready to merge. Please check here 🙏 |
|
@mpenkov will be with you shortly, we have a lot going on. Thanks for your patience. |
|
Merged. @koiizukag Congratulations on your first contribution to gensim 🥇 Thank you! |
This PR makes the following changes: to fix #2514