Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make UVFlag add smarter #653

Open
adampbeardsley opened this issue Aug 13, 2019 · 2 comments
Open

Make UVFlag add smarter #653

adampbeardsley opened this issue Aug 13, 2019 · 2 comments

Comments

@adampbeardsley
Copy link
Member

Right now the UVFlag add method requires an axis to be specified and it blindly concatenates. We should make it smarter to check for compatibility and figure out which axis to add along, like UVData. Similar to UVData, we should also add a fast_concat method.

@mkolopanis
Copy link
Member

The current implementation of add basically is fast_concat luckily. Just need to build up checks for a more safe add.

@bhazelton
Copy link
Member

Generally need to add more checking as is done with the other objects. In particular, make sure the right thing happens in the case of overlapping and differently sorted data.

see #1102 and #1105 for reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants