Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] cell can't be selected sometimes #102

Closed
imed-ghomari opened this issue Jun 4, 2022 · 7 comments
Closed

[BUG] cell can't be selected sometimes #102

imed-ghomari opened this issue Jun 4, 2022 · 7 comments
Assignees
Labels
bug Something isn't working reopen Issue that needs a second iteration

Comments

@imed-ghomari
Copy link
Collaborator

Describe the bug
Sometimes cells on newly created column can't be selected

To Reproduce

Files:

Steps:

  1. create column
  2. select cells

Expected behavior
cells can be selected

Screenshots

Screen.Recording.2022-06-04.at.2.46.28.PM.mov

Desktop (please complete the following information):

  • OS: MacOs monterey 12.3.1
  • Version Obsidian 0.14.6 Installer 0.14.6
@RafaelGB
Copy link
Owner

RafaelGB commented Jun 4, 2022

I will check it. Thanks

@RafaelGB RafaelGB added the triage Issue not tagged yet. talking to the user label Jun 4, 2022
@imed-ghomari
Copy link
Collaborator Author

if #114 is resolved, then this should be too.

I couldn't select the column because it was appearing on the right, just like the checkbox are appearing in #114.

@RafaelGB
Copy link
Owner

Looks like different issues. But could be check once Is released, thanks for comment about it

@RafaelGB RafaelGB added wontfix This will not be worked on and removed triage Issue not tagged yet. talking to the user labels Jun 21, 2022
@RafaelGB RafaelGB self-assigned this Jun 22, 2022
@imed-ghomari
Copy link
Collaborator Author

I was wrong, the bug is still present, the cells in the column can't be select because they are in the column to the right.

Screen.Recording.2022-06-30.at.5.12.58.PM.mov

@RafaelGB
Copy link
Owner

I will test it, could not reproduce it yet

@RafaelGB RafaelGB added bug Something isn't working reopen Issue that needs a second iteration and removed wontfix This will not be worked on labels Jun 30, 2022
@RafaelGB
Copy link
Owner

Okey, This happens just when you add a column with the "insert right" of the last column

I will investigate the cause

@RafaelGB
Copy link
Owner

Fixed controlling order of columns where are added or deleted with reactive strategy

const [columnOrder, setColumnOrder] = React.useState<ColumnOrderState>(
    columns.map((c) => c.id)
  );
  // Niveling number of columns
  if (columnOrder.length !== columns.length) {
    setColumnOrder(columns.map((c) => c.id));
  }

Now the cleanest way but does the job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working reopen Issue that needs a second iteration
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants