Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate plugin to react-table v8 + react18 #189

Closed
RafaelGB opened this issue Jul 4, 2022 · 9 comments
Closed

Migrate plugin to react-table v8 + react18 #189

RafaelGB opened this issue Jul 4, 2022 · 9 comments
Assignees
Labels
epic enhancement new feature or request that suppose a breaking change

Comments

@RafaelGB
Copy link
Owner

RafaelGB commented Jul 4, 2022

react-table v8 is stable now. The advantages of the version are too much important and all the issues have to wait until this is done

@RafaelGB RafaelGB self-assigned this Jul 4, 2022
@RafaelGB RafaelGB added the epic enhancement new feature or request that suppose a breaking change label Jul 4, 2022
@RafaelGB
Copy link
Owner Author

RafaelGB commented Jul 7, 2022

Due to the scale of this task, a separate project will be generated
https://github.com/users/RafaelGB/projects/3/views/1

@RafaelGB
Copy link
Owner Author

RafaelGB commented Jul 12, 2022

The core of the table is already migrated. Now we have to work on the user interface, since the current one with the flex strategy is not supported

Screenshot 2022-07-12 at 21 07 34

fun fact: With new version there is a native debug logs!
Number of renders per row before: 7
Number of renders per row now: 1

@RafaelGB
Copy link
Owner Author

btw: the DnD columns is removed (now supported with react18) and will be implemented from start with https://github.com/react-dnd/react-dnd/

@RafaelGB
Copy link
Owner Author

responsive table migrated and working, edition included.

Screenshot 2022-07-13 at 21 18 07

note: the objetive of 2.x.x its to migrate the actual dispatch strategy to https://github.com/pmndrs/zustand

@RafaelGB
Copy link
Owner Author

Far from perfect yet, but The DnD was reconstructed with another technology and its "working"
Compatible with resizing columns too!

Screen.Recording.2022-07-16.at.12.14.33.mov

@RafaelGB
Copy link
Owner Author

The core of the migration is finished I will prepare a beta this week

@Gentleman03
Copy link

Hey @RafaelGB I have table with 118 files and field add new barely works. It's incredibly laggy and easily freezes obsidian app. I have tried 1.8.2 and 2.0.0 beta 2 and it's the same. I have noticed that if I have put something into search and number of displayed books is smaller it doesn't lagg that bad as with whole table but it's still quite a significant lagg.

@RafaelGB
Copy link
Owner Author

hi @Gentleman03. Open a discussion and share your ddbb markdown file please. Will be attended properly

@Gentleman03
Copy link

hi @Gentleman03. Open a discussion and share your ddbb markdown file please. Will be attended properly

Sorry for the delay. I would like to keep my DB private so if that's ok I can upload it somewhere and I'll send you a link. I'll just need an email adress or any other contact channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic enhancement new feature or request that suppose a breaking change
Projects
None yet
Development

No branches or pull requests

2 participants