Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: quoted attributes from an imported CSV aren't respected #734

Closed
2 tasks done
Obsidian-user opened this issue Jan 6, 2023 · 3 comments
Closed
2 tasks done
Assignees
Labels
bug Something isn't working

Comments

@Obsidian-user
Copy link

Obsidian-user commented Jan 6, 2023

What happened?

When importing a CSV, every comma is treated like a data separator even when quoted / escaped.

For example, with the following CSV:

File, col2
"object 1, with note", object 2

I would expect

---
File: object 1, with note
col2: object 2
---

instead I get

---
File: object 1
col2: with note
undefined: object 2
---

What platform were you using?

Desktop

Version of the plugin

3.2.0

Relevant log output

No response

Are you using the latest version of the plugin in your Obsidian vault?

  • I have verified that I am on the latest version

Are you check if there is a similar issue?

  • I have verified that there are not similar issues
@Obsidian-user Obsidian-user added bug Something isn't working triage Issue not tagged yet. talking to the user labels Jan 6, 2023
@RafaelGB
Copy link
Owner

RafaelGB commented Jan 6, 2023

Hello @Obsidian-user, Thanks for the report

I will check this issue

@RafaelGB RafaelGB removed the triage Issue not tagged yet. talking to the user label Jan 6, 2023
@RafaelGB RafaelGB moved this from 🥶 backlog to 👩‍💻👨‍💻 In progress in Obsidian database plugin Roadmap Jan 16, 2023
@RafaelGB
Copy link
Owner

I will change the actual csv libraryper a custom solution we can parse better.

I am working on a plugin API for another Input/Output solutions and this tutorial could be an aprox https://refine.dev/blog/how-to-import-csv/

@RafaelGB
Copy link
Owner

This is the first step of a huge refactor Commit 4148045

It will fix this issue

@RafaelGB RafaelGB moved this from 👩‍💻👨‍💻 In progress to 🏁👍 Ready for the next version in Obsidian database plugin Roadmap Jan 21, 2023
@RafaelGB RafaelGB moved this from 🏁👍 Ready for the next version to <g-emoji fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/2705.png" alias="white_check_mark" class="g-emoji">✅</g-emoji> Done in Obsidian database plugin Roadmap Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants