Skip to content

Commit

Permalink
test: fix flaky test-runner-exit-code.js
Browse files Browse the repository at this point in the history
test/parallel/test-runner-exit-code.js failed in a recent CI run
with the following error:

+ actual - expected

+ 'TAP version 13\n' +
+   '# Subtest: /home/iojs/build/workspace/...'
- 'TAP version 13\n'

This commit resolves that flakiness.

Refs: https://ci.nodejs.org/job/node-test-commit-linuxone/35759/
PR-URL: nodejs#46138
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
  • Loading branch information
cjihrig authored and RafaelGSS committed Jan 17, 2023
1 parent 4e4d6e7 commit 36ac341
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions test/parallel/test-runner-exit-code.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ async function runAndKill(file) {
});
const [code, signal] = await once(child, 'exit');
await finished(child.stdout);
assert.match(stdout, /not ok 1/);
assert.match(stdout, /# cancelled 1\n/);
assert(stdout.startsWith('TAP version 13\n'));
assert.strictEqual(signal, null);
assert.strictEqual(code, 1);
}
Expand Down

0 comments on commit 36ac341

Please sign in to comment.