Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot won't play Deezer links gotten from the Share button #68

Open
miniluz opened this issue Apr 3, 2024 · 5 comments
Open

Bot won't play Deezer links gotten from the Share button #68

miniluz opened this issue Apr 3, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@miniluz
Copy link

miniluz commented Apr 3, 2024

Describe your context
I'm using the default values, I just downloaded the image and used Docker.

The path to the bug
I simply tried to !play (! being my prefix) a Deezer link (ej. https://deezer.page.link/md6VvKoZ6uHeCiicA) and I'm getting a "Nothing Found. This type of input was too strange, try something else".

Screenshots
image
image

@miniluz miniluz added the bug Something isn't working label Apr 3, 2024
@miniluz miniluz changed the title Bug Bot won't play Deezer links Apr 3, 2024
@miniluz
Copy link
Author

miniluz commented Apr 3, 2024

Reading the code I see that you expect links to be in the format of www.deezer.com. Is there a reason why deezer.page.link ones aren't supported? They're what you get when you click the "share" button.

@miniluz miniluz changed the title Bot won't play Deezer links Bot won't play Deezer links gotten from the Share button Apr 3, 2024
@RafaelSolVargas
Copy link
Owner

Hello!
When I wrote that piece of code i didn't knew about those types of link, have you tried to change the source code to allow this type of link to see if the Deezer module can identify those musics?

@miniluz
Copy link
Author

miniluz commented Apr 4, 2024

I was gonna look into it, but playing the links with the expected format still results in a quality that's too low for what I'm looking for. Thank you anyways! If I do come back to this, I'll make a PR.

@miniluz miniluz closed this as completed Apr 4, 2024
@miniluz
Copy link
Author

miniluz commented Apr 4, 2024

Oh. Missclick. I'm not sure if you want this closed?

@RafaelSolVargas
Copy link
Owner

I'll leave it open to implement this little change when i got the time

@RafaelSolVargas RafaelSolVargas added enhancement New feature or request and removed bug Something isn't working labels Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants