Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component breaks KNX core integration #21

Closed
farmio opened this issue May 2, 2023 · 7 comments
Closed

Component breaks KNX core integration #21

farmio opened this issue May 2, 2023 · 7 comments

Comments

@farmio
Copy link

farmio commented May 2, 2023

This replaces the xknx version required by the core KNX integration, rendering it unusable.
Please don't pin-require outdated xknx versions in your component.

See https://community.home-assistant.io/t/secureconfig-error-in-knx-integration/566793

@RainerStaude
Copy link
Owner

I thought the xknx version from manifest.json requirements (of Becker custom integration) will only be used for this integration. I was not aware it overwrites the xknx version used for HA core.

@farmio
Copy link
Author

farmio commented May 3, 2023

Great! Maybe see this post (and few following) for an alternative approach that would probably be more future proof: https://community.home-assistant.io/t/yet-another-time-controlled-cover-rflink/72759/111?u=farmio

or here nagyrobi/home-assistant-custom-components-cover-rf-time-based#50

@Mattes83
Copy link

Mattes83 commented May 3, 2023

Unfortunately the pinning was neccessary. In the current version TravelCalculator has no "_calculate_travel_time"

@farmio
Copy link
Author

farmio commented May 3, 2023

It was just renamed https://github.com/XKNX/xknx/blob/f5b71ca55cb7609065563b219d705d7666075ec1/xknx/devices/travelcalculator.py#L159

But I think it's still not a good idea to import a 16kLOC library for some side-show proportion calculations.

@RainerStaude RainerStaude reopened this May 3, 2023
@RainerStaude
Copy link
Owner

You guys make me crazy. But that is open source 😉
@farmio I like you care about 16k. That reminds me at the daily fight as HW developer with my SW colleaques. But for a RasPi or even larger system that shouldn't be an issue.
And I tested this change yesterday, but I'm running an previous version of HASS.
I think I will just copy the travelcalculator ...

@RainerStaude
Copy link
Owner

Done 😄
Hope this works now

@farmio
Copy link
Author

farmio commented May 3, 2023

Thank you very much! Users of KNX and your component will appreciate it 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants