From d55e95a3e60b3137d48ac224c6c190571827c828 Mon Sep 17 00:00:00 2001 From: Darshan Sen Date: Sun, 17 Apr 2022 19:15:20 +0530 Subject: [PATCH] build: improve the format-cpp error message Since we run the formatter only on PRs that are targeting the master branch, let's specify that. Refs: https://github.com/nodejs/node/pull/42681#discussion_r849624676 Signed-off-by: Darshan Sen --- .github/workflows/linters.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/linters.yml b/.github/workflows/linters.yml index 312ba0b3c9706a..fa761f4f9de044 100644 --- a/.github/workflows/linters.yml +++ b/.github/workflows/linters.yml @@ -78,7 +78,7 @@ jobs: echo echo 'ERROR: Please run:' echo - echo ' CLANG_FORMAT_START="$(git merge-base HEAD )" make format-cpp' + echo " CLANG_FORMAT_START="$\(git merge-base HEAD ${GITHUB_BASE_REF}\)" make format-cpp" echo echo 'to format the commits in your branch.' exit "$EXIT_CODE"