Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Style] Dark mode background change #549

Closed
4 of 6 tasks
SplinterSword opened this issue Feb 8, 2024 · 5 comments · Fixed by #557
Closed
4 of 6 tasks

[Style] Dark mode background change #549

SplinterSword opened this issue Feb 8, 2024 · 5 comments · Fixed by #557
Assignees
@SplinterSword
Labels
Easy IWOC2k24 (10 Points) ✨, JWOC2k24 (1 Point) 🎉, SWOC2k24 Level-1 (20 Points) 💫 enhancement ✨ New feature or request JWOC JWOC 2k24 Open Source Program style tweak 🎨 Improve the website style or formatting

Comments

@SplinterSword
Copy link
Contributor

What's the style idea?

We need to improve the dark mode. Unlike the light mode the dark mode has no wallpaper or design to it. It is just a grey background which doesn't look very good.

Checklist

  • I have checked the existing issues.
  • I follow Contributing Guidelines of this project.
  • I am a IWOC'24 contributor.
  • I am a JWOC'24 contributor.
  • I am a SWOC'24 contributor.

Code of Conduct
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2024

Hey @SplinterSword, Welcome to the project Beautiify! 🎊
Thanks for opening an issue! 🙌 Please wait for the issue to be assigned. Happy Coding!! ✨

@SplinterSword
Copy link
Contributor Author

image_2024-02-08_194808094
Like we can add this image as a dark mode background

@Rakesh9100
Copy link
Owner

Dark mode cards is changed now, so can you pls tell what changes you want to do now after looking the new changes in the website again @SplinterSword

@Rakesh9100 Rakesh9100 added the question 🤔 Further information is requested label Feb 8, 2024
@SplinterSword
Copy link
Contributor Author

Only the position of the dark mode icon is changed.
I wanted to change the background of it.
Like we have this background right now.
image

I want to change it to this.
image

@Rakesh9100
Copy link
Owner

Okay proceed, let's see if it looks good @SplinterSword

@Rakesh9100 Rakesh9100 added JWOC JWOC 2k24 Open Source Program and removed question 🤔 Further information is requested labels Feb 10, 2024
@Rakesh9100 Rakesh9100 changed the title Dark mode changes [Style] Dark mode background changes Feb 10, 2024
@SplinterSword SplinterSword mentioned this issue Feb 11, 2024
Merged
@Rakesh9100 Rakesh9100 added enhancement ✨ New feature or request Easy IWOC2k24 (10 Points) ✨, JWOC2k24 (1 Point) 🎉, SWOC2k24 Level-1 (20 Points) 💫 labels Feb 11, 2024
@Rakesh9100 Rakesh9100 changed the title [Style] Dark mode background changes [Style] Dark mode background change Feb 19, 2024
@Rakesh9100 Rakesh9100 added the style tweak 🎨 Improve the website style or formatting label Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SplinterSword SplinterSword

Labels
Easy IWOC2k24 (10 Points) ✨, JWOC2k24 (1 Point) 🎉, SWOC2k24 Level-1 (20 Points) 💫 enhancement ✨ New feature or request JWOC JWOC 2k24 Open Source Program style tweak 🎨 Improve the website style or formatting
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Darkmode Background changed
2 participants
@SplinterSword @Rakesh9100