Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Info on hub.docker.com still outdated #20

Closed
Tekki opened this issue Nov 18, 2018 · 9 comments
Closed

Info on hub.docker.com still outdated #20

Tekki opened this issue Nov 18, 2018 · 9 comments

Comments

@Tekki
Copy link
Contributor

Tekki commented Nov 18, 2018

My comment in #15 didn't get noticed, I open a new issue.
Your repo on Docker Hub is not an automated build, you have to update the README manually.
Here you find more infos about automated builds. Seems it isn't possible to convert an existing repo, there is an open issue on Docker: docker/hub-feedback#794

I don't want to be the one who always complains, so I'll propose some changes to the README.

@zakame
Copy link
Member

zakame commented Nov 18, 2018

Sounds like one needs to create a PR updating https://github.com/docker-library/docs/tree/master/rakudo-star

This can be semi-automated via adding an update.sh in this repo and letting @docker-library-bot commit here, cf Perl/docker-perl#24 (comment)

@Tekki
Copy link
Contributor Author

Tekki commented Apr 13, 2019

Now that 2019.03 is on Dockerhub, why is the README still not updated?

@tianon
Copy link
Contributor

tianon commented Jun 1, 2019

That'd be because nobody has made a PR to https://github.com/docker-library/docs/tree/master/rakudo-star 😄

To be clear, giving @docker-library-bot commit bits here would not do anything with README.md -- the format in https://github.com/docker-library/docs/tree/master/rakudo-star is different (and templated so that all official images have a consistent image description format).

The approach we take with images maintained under https://github.com/docker-library is to make the README.md inside the repository just a stub that points to Docker Hub as the canonical source (see https://github.com/docker-library/golang#readme, for example), which helps us avoid duplicated documentation effort.

Some other images prefer to keep the documentation on Docker Hub explicitly slim and link elsewhere for documentation (either to a markdown file in GitHub or better yet to actual upstream documentation content so the documentation for the image lives within the proper upstream documentation directly).

@JJ
Copy link
Contributor

JJ commented Jun 2, 2019 via email

@Tekki
Copy link
Contributor Author

Tekki commented Jun 2, 2019

I have permission, and it's not required. But I think that an official maintainer has to make this PR.

@tianon
Copy link
Contributor

tianon commented Jun 3, 2019

It doesn't require any permissions of any kind -- we just need someone to take a look at https://github.com/docker-library/docs/blob/master/rakudo-star/content.md and provide a PR to that repository updating it as desired (which we then typically ask one of the image maintainers to sign-off on whether they approve of the changes).

@JJ
Copy link
Contributor

JJ commented Feb 11, 2020

Even more outdated now...

@moritz
Copy link
Contributor

moritz commented Apr 29, 2020

docker-library/docs#1704

@moritz
Copy link
Contributor

moritz commented Apr 30, 2020

I've updated the info that I could find how to update. If stuff's still wrong, please open a merge request against docker-library/docs.

@moritz moritz closed this as completed Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants