-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds shared volume #6
Conversation
And documentation on how to use it.
(I know I have the privs to merge this, but maybe someone else wants to check it out) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this on an older docker image and it works fine:
docker run -t -v `pwd`:/home/perl6 rakudo-star perl6 /home/perl6/ls.p6
Is the volume really needed?
|
||
$ docker run -t -v `pwd`:/home/perl6/app rakudo-star /home/perl6/app/ls.p6 | ||
|
||
where we mal the local file ls.p6 (in this directory) to the remote |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does mal
mean here? It sounds like a typo, but I may be wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
totally typo. Should be map. Will fix that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Volume is not really needed. It's just a convenient place to put scripts. You can create new volumes with -v all the time.
And adding a bit of more context.
As I noted over in docker-library/official-images#2599, I'm having a hard time understanding what's added by having an explicit |
No, not really. It's just a convention, |
I think the description in docker-library/official-images#2437 (comment) is decent context on why this
|
This reverts commit 7724855, reversing changes made to a7548f1. Explanation: #7 #6 (comment)
OK, you have a point here.
|
And documentation on how to use it.
These are very minor changes but add to usability.