Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework of advanced view #1028

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Rework of advanced view #1028

merged 1 commit into from
Aug 19, 2021

Conversation

Mel-kior
Copy link
Contributor

This is a rework of the advanced views to make it more organized and useful

Change :

  • Remove all the text ( was taking too much space, specially when translated, and units tells us what the value is)
  • Make the tip temp large ( better visibility )
  • Value have fixed position ( no more clipping from too long translated text )
  • Remove the set temperature ( I find it less useful than a large tip temp )
  • Make the cool down temp blink if option set ( timing : on 700 ms | off 300ms )

Soldering view :
solderingScreen

Idle view :
idleScreen

@Ralim
Copy link
Owner

Ralim commented Aug 19, 2021

Looks good, I approve.
Can you fix the formatting and then this can be merged :)
(You can run make style to do this for you)

@Mel-kior Mel-kior force-pushed the AdvancedViewRework branch from a2cce78 to 9aa3434 Compare August 19, 2021 19:48
@Mel-kior
Copy link
Contributor Author

Done!

@Ralim Ralim merged commit fc47c71 into Ralim:master Aug 19, 2021
@Ralim
Copy link
Owner

Ralim commented Aug 19, 2021

🤗 Thank you :)
Appreciate the effort you have done for this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants