Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added LT translations to new entries. #1076

Merged
merged 1 commit into from
Sep 26, 2021
Merged

Added LT translations to new entries. #1076

merged 1 commit into from
Sep 26, 2021

Conversation

vini-nu
Copy link
Contributor

@vini-nu vini-nu commented Sep 26, 2021

Tested locally on TS80P, TS100.

On both devices on English and Lithuanian languages "text2": ["Screen", "Brightness"], and "text2": ["Screen", "Invert"], doesn't show up on the menus. Only sunny and inverting icons are showed with their respective values without text2.

@Ralim
Copy link
Owner

Ralim commented Sep 26, 2021

At the moment its just the icon as:
(a) it was contributed with them and
(b) not sure if translations will all fit.
so
(c) waiting to see what people say

@Ralim Ralim merged commit f9fa246 into Ralim:master Sep 26, 2021
@discip
Copy link
Collaborator

discip commented Sep 26, 2021

@Ralim
If you ask me, the way @alvinhochun solved this, it is highly unambiguous in any tongue out there! 👍
I would even prefer, if there wer more icons instead of tiny texts, assuming the specific entry is 'iconizable'! 😁

@Ralim
Copy link
Owner

Ralim commented Sep 26, 2021

I agree it is a rather neat solution.
I dont think the entire menu can be iconised but for some it may be preferable :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants