Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logo update #1223

Merged
merged 11 commits into from
Feb 11, 2022
Merged

logo update #1223

merged 11 commits into from
Feb 11, 2022

Conversation

discip
Copy link
Collaborator

@discip discip commented Feb 10, 2022

No description provided.

@discip discip marked this pull request as draft February 10, 2022 00:55
@discip discip marked this pull request as ready for review February 10, 2022 01:03
@River-Mochi
Copy link
Contributor

I just installed this pull but I do not see IronOS logo in flat or animated on screen.

version shows as 2.16.E10F958

@Ralim
Copy link
Owner

Ralim commented Feb 10, 2022

@discip
Please dont create a logo per frame 😓 They are chewing up space in github and I doubt anyone is going to flash a particular frame?

@discip
Copy link
Collaborator Author

discip commented Feb 10, 2022

@Ralim

  1. I am sorry, I did not mean to clutter github. 😅
    My intention was to provide the necessary parts for an animation that I was capable of delivering.

    But except for the python part I only followed your guide Feature: Custom GIF on boot-up #446 (comment).

    And additionally I did indirectly ask if this would work Figure out OLED dfu mode text IronOS-dfu#1 (comment).

  2. Judging by the space restriction, it might be good to remove the .dfu & .hex files as well, since the python script to convert from .png to the desired format is also present. (And eventually adding an example batch to execute the conversion.)

    What do you think?

kind regards

@Ralim
Copy link
Owner

Ralim commented Feb 11, 2022

I'm happy for .dfu and hex files ; it was mostly just the animation ones since the way to get it to work would be a bit different and would need to create one "large" hex of all the frames :)

@discip
Copy link
Collaborator Author

discip commented Feb 11, 2022

How should the individual frames be stacked?
Should I try making one?

@Ralim
Copy link
Owner

Ralim commented Feb 11, 2022

Dont know yet, need to figure out a reasonable way to squeeze it down to fit onto a page of flash (1024 bytes)

@discip
Copy link
Collaborator Author

discip commented Feb 11, 2022

Than that'll have to wait, since I am not capable of achieving this. 😁

But maybe @alvinhochun is able to provide help, if he has time at hand and is willing that is.

He is definitely more than capable of implementing this kind of thing.

@Ralim Ralim merged commit 3869003 into Ralim:master Feb 11, 2022
@discip discip deleted the logo-update branch February 11, 2022 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants