-
-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated documents, fixed English Translation #1400
Conversation
Therefore the Pinecil and TS100 perform poorly when run off 12V power supplies and may issue a `Thermal Runaway` message (weak power supply). | ||
|
||
#### Use an [Ohm calculator](https://www.rapidtables.com/calc/electric/power-calculator.html#dc) to quickly derive watts. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are going to do this table, can we also do the TS80P a tiny table with 9/12V values?
Documentation/Settings.md
Outdated
@@ -243,7 +249,7 @@ When powered by a battery, this adjusts the minimum voltage per cell before shut | |||
|
|||
On device help text: | |||
|
|||
Minimum allowed voltage per cell (3S: 3 - 3.7V | 4-6S: 2.4 - 3.7V) | |||
Minimum allowed volts per cell (3S: 3 - 3.7V | 4S-6S: 2.4 - 3.7V) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"volts" is slang, it would be perferable to keep "voltage" if we can
I think you miss the concept of community driven open source means. it means you are not the dictator of what is needed or not needed. There is no need for you to review the edits I put in. before you did that yesterday I was fine, I would submit my new documents and Ralim would review them. I suggest you stop looking at my PR's since you think they are "time consuming unnecessities" You also have to keep in mind that I also was editing several of these documents many months before you started editing them. if you flip that around, you were changing ones that I had done previously. I put a lot of work into many of the documents where I see you also came in and changed some if it but I did not start yelling at you or sending you all these rude comments like your approach and tone. For example, the Hall Sensor document. I wrote that originally because I have installed a lot of them and experimented a lot with them. Before I wrote the detailed the document, there was just a short sentence. people were confused about the method and we did not have full instructions. Now we do. I put a lot of work into the documents many months ago and then took a break from them for little while and was going back to expand them as I intended to do last year since our group has complained that there are not enough details and instructions. slowly I'm adding to them and expanding the information. if you do not want todo personal attacks then don't write your comments the way they are done. and don't yell at people with "!" it is not going to get you far. stop writing such insulting things to people. Since you can't stop being rude and your note was condescening, stop looking at my PR's altogether. there is no need at all. Ralim used to just review them. need to be mature enough to work with other editors and just yell rude comments . recognize that other people like me put a lot of work into the documents and were just going back in to continue the work I started last year. You make assumtions that are not valid thinking I just started writing documents. I'm coming back to documents that I left a long time ago. |
With the due respect I take the liberty to intervene as I consider myself a small part of this project. Thank you, Federico. |
Doc updates, changed some slang or colloquial wording.
Fixed problem with Translation EN file and Hall Sensor spacing.
Translation English updates, shortened scrolling text for clarity and ease of reading
Expanded documents with more sections and details, i.e. Power doc, temperature, Hardware issues
What is the current behavior?
translation editor did not work correctly with English file.
What is the new behavior (if this is a feature change)?
increased maxlen2 for hall sensor, now Translation_EN can be used correctly and will not have a red section for hall sensor.