Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated documents, fixed English Translation #1400

Merged
merged 111 commits into from
Sep 1, 2022
Merged

Updated documents, fixed English Translation #1400

merged 111 commits into from
Sep 1, 2022

Conversation

River-Mochi
Copy link
Contributor

  • What kind of change does this PR introduce?

Doc updates, changed some slang or colloquial wording.
Fixed problem with Translation EN file and Hall Sensor spacing.
Translation English updates, shortened scrolling text for clarity and ease of reading
Expanded documents with more sections and details, i.e. Power doc, temperature, Hardware issues

  • What is the current behavior?
    translation editor did not work correctly with English file.

  • What is the new behavior (if this is a feature change)?
    increased maxlen2 for hall sensor, now Translation_EN can be used correctly and will not have a red section for hall sensor.

Documentation/Settings.md Outdated Show resolved Hide resolved
Therefore the Pinecil and TS100 perform poorly when run off 12V power supplies and may issue a `Thermal Runaway` message (weak power supply).

#### Use an [Ohm calculator](https://www.rapidtables.com/calc/electric/power-calculator.html#dc) to quickly derive watts.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are going to do this table, can we also do the TS80P a tiny table with 9/12V values?

Documentation/Menu.md Outdated Show resolved Hide resolved
@@ -243,7 +249,7 @@ When powered by a battery, this adjusts the minimum voltage per cell before shut

On device help text:

Minimum allowed voltage per cell (3S: 3 - 3.7V | 4-6S: 2.4 - 3.7V)
Minimum allowed volts per cell (3S: 3 - 3.7V | 4S-6S: 2.4 - 3.7V)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"volts" is slang, it would be perferable to keep "voltage" if we can

@River-Mochi
Copy link
Contributor Author

River-Mochi commented Aug 31, 2022

@river-b In general you are doing a good job by looking through all the documentations and adjusting them.

However, my advice is to keep in mind that other people have already put a lot of effort and time into this, and for the most part they did what they did with a purpose in mind.

If you start to change everything, though, which undoubtedly takes a great amount of time, you could end up unintentionally changing things for the worse. In turn, the developer has to go through every single bit that you've changed before merging it in, which again takes a tremendous amount of time.

So if your change does not

  1. save space, or
  2. add information, or
  3. correct false statements, or
  4. correct grammar.

Than please consider these changes as time consuming unnecessities.

This is no personal attack! I hope you understand.

Thanks in advance

I think you miss the concept of community driven open source means. it means you are not the dictator of what is needed or not needed.
when you say things like this, it is another example that you are being incredibly rude.
" Than please consider these changes as time consuming unnecessities."

There is no need for you to review the edits I put in. before you did that yesterday I was fine, I would submit my new documents and Ralim would review them. I suggest you stop looking at my PR's since you think they are "time consuming unnecessities"

You also have to keep in mind that I also was editing several of these documents many months before you started editing them. if you flip that around, you were changing ones that I had done previously.
You made changes to the English translation document that I had put there a while ago. I also had a purpose in mind and put a lot of effort into it. I don't know who changed it but we used to have the English document default to Celcius, and now Fahrenheit is set to true instead of false.

I put a lot of work into many of the documents where I see you also came in and changed some if it but I did not start yelling at you or sending you all these rude comments like your approach and tone.
You have to stop yelling at people. you have been wrong a few times and do this in a tone that is unneccessary.

For example, the Hall Sensor document. I wrote that originally because I have installed a lot of them and experimented a lot with them. Before I wrote the detailed the document, there was just a short sentence. people were confused about the method and we did not have full instructions. Now we do.

I put a lot of work into the documents many months ago and then took a break from them for little while and was going back to expand them as I intended to do last year since our group has complained that there are not enough details and instructions. slowly I'm adding to them and expanding the information.

if you do not want todo personal attacks then don't write your comments the way they are done. and don't yell at people with "!" it is not going to get you far. stop writing such insulting things to people.

Since you can't stop being rude and your note was condescening, stop looking at my PR's altogether. there is no need at all. Ralim used to just review them. need to be mature enough to work with other editors and just yell rude comments . recognize that other people like me put a lot of work into the documents and were just going back in to continue the work I started last year. You make assumtions that are not valid thinking I just started writing documents. I'm coming back to documents that I left a long time ago.

@ghost
Copy link

ghost commented Aug 31, 2022

With the due respect I take the liberty to intervene as I consider myself a small part of this project.
I please you to keep in mind that each of us is given the ability to know a partial reality of which words are a stunted expression, even more partial when each of us comes from different cultural backgrounds.
All divergences within the project have been able to convene in the realization of a single purpose: the realization of the project itself.
To that end, I beg you to treat opinions as such, and I would point out how an accusative argument never seems to be a solving approach to the arising of disputes.
That said, I ask you softly to reason on the merits of the issue and to maintain a resolving, amicable and open approach, always in the interest of the project itself.

Thank you, Federico.

@Ralim Ralim merged commit 904428e into Ralim:dev Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants