-
-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New translations format #1493
New translations format #1493
Conversation
Update make_translation.py
@Ralim For the
|
"OffString": { | |
"message": "Off" |
The following 3 texts are garbled in that:
- they do not scroll &
- only the lower half is displayed:
IronOS/Translations/translation_EN.json
Lines 33 to 40 in fba6997
"SettingsCalibrationWarning": { "message": "Before rebooting, make sure tip & handle are at room temperature!" }, "CJCCalibrating": { "message": "calibrating" }, "SettingsResetWarning": { "message": "Are you sure you want to restore default settings?"
For the Pinecil
:
- Single-lang version:
Same asTS80P
. - Multi-lang version is even worse:
Except for the graphics, literally every entry is a wild jumble of symbols, letters and numbers.
Even the texts that should be large are displayed in the same disordered style but in 2 stacked small lines.
Looking through the changes you made, I was not able to spot the responsible part.
thanks in advance
kind regards
Thanks for checking; will try and patch. Was expecting a few of these to break. |
The breakage that is left is in compression for translation blobs. Will need to trace and/or rework when i get more time. (Will take more effort than I hoped) |
@Ralim |
Yeah; though its slightly less broken. |
Ah!, just noticed that the issues with the single-language-version are gone. 👍🏻In the meantime, did you have a chance to think about what else could have gone wrong? 😊 |
@discip |
Would be mint if you could give it a quick pass over. |
Thanks. |
Works as expected for both
|
Amazing thank you. No rush was implied, you still tested before I woke up lol. 😍 |
Work in progress; looking to migrate translations to be editable using Weblate's online editing system as well. To make it easier for people who dont like the translation editor or editing json files directly.
This will not merge until I have confirmed Libre project hosting with Weblate. But open for criticisms :)Hosting confirmed.
Now just waiting for 2.20 to go out and bugs fixed.This should be good to go. Waiting to test a bit more and then we are good and I can finally finish Weblate integrations fully.