Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New translations format #1493

Merged
merged 26 commits into from
Jan 22, 2023
Merged

New translations format #1493

merged 26 commits into from
Jan 22, 2023

Conversation

Ralim
Copy link
Owner

@Ralim Ralim commented Dec 7, 2022

Work in progress; looking to migrate translations to be editable using Weblate's online editing system as well. To make it easier for people who dont like the translation editor or editing json files directly.

This will not merge until I have confirmed Libre project hosting with Weblate. But open for criticisms :)
Hosting confirmed.

Now just waiting for 2.20 to go out and bugs fixed.

This should be good to go. Waiting to test a bit more and then we are good and I can finally finish Weblate integrations fully.

@Ralim Ralim marked this pull request as ready for review December 7, 2022 20:00
@discip
Copy link
Collaborator

discip commented Dec 9, 2022

@Ralim
Greetings Ben,
unfortunately I have to report, that something broke with this PR.

For the TS80P:

  1. "OffString": {
    "message": "Off"
    is misspaced: Instead of being drawn on the right, it overlays the lower half of the menu name on the left.

  2. The following 3 texts are garbled in that:

    1. they do not scroll &
    2. only the lower half is displayed:
      "SettingsCalibrationWarning": {
      "message": "Before rebooting, make sure tip & handle are at room temperature!"
      },
      "CJCCalibrating": {
      "message": "calibrating"
      },
      "SettingsResetWarning": {
      "message": "Are you sure you want to restore default settings?"

For the Pinecil:

  1. Single-lang version:
    Same as TS80P.
  2. Multi-lang version is even worse:
    Except for the graphics, literally every entry is a wild jumble of symbols, letters and numbers.
    Even the texts that should be large are displayed in the same disordered style but in 2 stacked small lines.

Looking through the changes you made, I was not able to spot the responsible part.

thanks in advance
kind regards

@Ralim
Copy link
Owner Author

Ralim commented Dec 10, 2022

Thanks for checking; will try and patch. Was expecting a few of these to break.

@Ralim
Copy link
Owner Author

Ralim commented Dec 11, 2022

The breakage that is left is in compression for translation blobs. Will need to trace and/or rework when i get more time. (Will take more effort than I hoped)

@discip
Copy link
Collaborator

discip commented Jan 3, 2023

@Ralim
I don't know if I was supposed to test after this commit, but I did and unfortunately multilingual is still broken.

@Ralim
Copy link
Owner Author

Ralim commented Jan 3, 2023

Yeah; though its slightly less broken.
Just still trying to figure out how I've managed to break the index lookup table sigh.

@discip
Copy link
Collaborator

discip commented Jan 9, 2023

@Ralim

Ah!, just noticed that the issues with the single-language-version are gone. 👍🏻

In the meantime, did you have a chance to think about what else could have gone wrong? 😊

@Ralim Ralim added this to the 2.21 milestone Jan 17, 2023
@Ralim
Copy link
Owner Author

Ralim commented Jan 22, 2023

@discip
Multi language and single languages should now be fixed 😓
Have bought back up to sync with dev as well.

@Ralim
Copy link
Owner Author

Ralim commented Jan 22, 2023

Would be mint if you could give it a quick pass over.
Also validate the reboot on settings reset works fine on Pinecil 1 and 2 for me here.

@discip
Copy link
Collaborator

discip commented Jan 22, 2023

Thanks.
Unfortunately I'm currently not at home.
Will definitely do, as soon as I am back.

@discip
Copy link
Collaborator

discip commented Jan 22, 2023

Works as expected for both TS80P and Pinecil. 👍🏻

@Ralim
Copy link
Owner Author

Ralim commented Jan 22, 2023

Amazing thank you.

No rush was implied, you still tested before I woke up lol. 😍

@Ralim Ralim merged commit bf277e5 into dev Jan 22, 2023
@Ralim Ralim deleted the new-translations-format branch January 22, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants