Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Core/Drivers to the scope of style check by clang-format #1754

Merged
merged 5 commits into from
Jul 28, 2023

Conversation

ia
Copy link
Collaborator

@ia ia commented Jul 22, 2023

  • Please check if the PR fulfills these requirements
  • The changes have been tested locally
  • There are no breaking changes
  • What kind of change does this PR introduce?
    Extend style check for the repo code base.

  • What is the current behavior?
    Before we agreed to exclude Core/Drivers from clang-format scope.

  • What is the new behavior (if this is a feature change)?
    It turned out there is no so much changes required to put Core/Drivers under scope of style check back.

  • Other information:
    I'm fully aware that OLED as it is now will probably be gone soon but I really like to help making the project at least a bit more tidy so here is my another one very humble little contribution. :)

@Ralim
Copy link
Owner

Ralim commented Jul 22, 2023

I'll have a look into how much of a mess with will be to rebase on. Won't be near PC for a bit though so don't panic if it's a lil quiet 😊

@ia
Copy link
Collaborator Author

ia commented Jul 22, 2023

I'll have a look into how much of a mess with will be to rebase on.

Let's say I don't mind to do some extra formatting in your patches for you so you could work on more important things. :)

Won't be near PC for a bit though

If it's holiday/vacation/etc. then I sincerely wish you a really good recreational time. ;)

so don't panic if it's a lil quiet blush

Sure, no problem. Thanks for the warning though.

@Ralim Ralim enabled auto-merge (squash) July 28, 2023 09:37
@Ralim Ralim merged commit 65ac2e2 into Ralim:dev Jul 28, 2023
@ia ia deleted the clang-format-drivers branch July 28, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants