Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fake s3 store in tests doesn't use locks to store data in a map #1289

Open
raghavendra-talur opened this issue Mar 26, 2024 · 0 comments · May be fixed by #1324
Open

Fake s3 store in tests doesn't use locks to store data in a map #1289

raghavendra-talur opened this issue Mar 26, 2024 · 0 comments · May be fixed by #1324
Labels
good first issue Good for newcomers test Testing related issue

Comments

@raghavendra-talur
Copy link
Member

Recently, we have seen "concurrent map writes detected" error in our ginkgo tests. This is happening because the fake s3 store we have in the tests uses a simple map to store the data and doesn't use any lock to prevent concurrent writes.

We need to enhance the store to make it concurrency proof.

Line https://github.com/RamenDR/ramen/blob/main/controllers/s3utils_test.go#L93
@nirs nirs added good first issue Good for newcomers test Testing related issue labels Mar 27, 2024
Sheetalpamecha added a commit to Sheetalpamecha/ramen that referenced this issue Apr 8, 2024
@Sheetalpamecha
s3utils_test: Optimize objectstore map to prevent concurrent writes
a012c92 
Fixes: RamenDR#1289
Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
@Sheetalpamecha Sheetalpamecha linked a pull request Apr 8, 2024 that will close this issue
Draft
Sheetalpamecha added a commit to Sheetalpamecha/ramen that referenced this issue Apr 8, 2024
@Sheetalpamecha
s3utils_test: Optimize objectstore map to prevent concurrent writes
f7c8289 
Fixes: RamenDR#1289
Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
@ShyamsundarR ShyamsundarR mentioned this issue May 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers test Testing related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

s3utils_test: Optimize objectstore map to prevent concurrent writes Sheetalpamecha/ramen
2 participants
@nirs @raghavendra-talur