New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from using Sets from k8s.io/apimachinery/pkg/util/sets as it is deprecated #1486

Open

ShyamsundarR opened this issue Jul 15, 2024 · 2 comments

Member

ShyamsundarR commented Jul 15, 2024

Potentially using slices.Contains instead of sets in these instances.

Member

nirs commented Jul 21, 2024

@ShyamsundarR where do you see that the package is deprecated?

The typed sets are:
https://pkg.go.dev/k8s.io/apimachinery/pkg/util/sets#String

But the generic set is not:
https://pkg.go.dev/k8s.io/apimachinery/pkg/util/sets#Set

Member Author

ShyamsundarR commented Jul 22, 2024

Correct, typed sets are and not generic ones, and requires a switch to the generic ones in code where used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment