Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Titlebar move action does not pop down context menu #255

Closed
RamonUnch opened this issue Aug 6, 2022 · 22 comments · Fixed by #260
Closed

Titlebar move action does not pop down context menu #255

RamonUnch opened this issue Aug 6, 2022 · 22 comments · Fixed by #260
Labels
bug Something isn't working

Comments

@RamonUnch
Copy link
Owner

I was having a look at the SmartSystemMenu you recommended and came across another bug.
When the "right click action menu" title bar action is disabled, the native menu doesn't disappear on left click.

explorer_lfF0hzRRqv.mp4

This is before I installed the SmartSystemMenu.
So maybe solving this would solve the Action menu not disappearing sometimes.
idk just taking a guess.

Originally posted by @rp1231 in #233 (comment)

@RamonUnch
Copy link
Owner Author

RamonUnch commented Aug 6, 2022

hooks1.55test9_i386.zip
hooks1.55test9_x64.zip


EDIT in the `[Advanced]` section of the .ini file.
TTBMoveClick=0
; If set to 1, then a click will be sent to the titlebar when
; moving with AltSnap from the titlebar. This can help to pop down
; context menu when the drag starts. AutoFocus needs to be enabled
; for this option to have effect.

@RamonUnch RamonUnch added the bug Something isn't working label Aug 6, 2022
@Ichisich
Copy link

Ichisich commented Aug 6, 2022

Does close the menus and panels reliably, but produces a clearly noticeable delay and prevents MoveUp.

@RamonUnch
Copy link
Owner Author

Does close the menus and panels reliably, but produces a clearly noticeable delay and prevents MoveUp.

Strange, for me MoveUp works. and I do not see much of a delay.
Give me your .ini file again, maybe I can figure it out.

@Ichisich
Copy link

Ichisich commented Aug 6, 2022

MoveUp works when I hold move down as long as the additional delay introduced with TTBMoveClick.
AltSnap.zip

Attempt to visualize the delay:
https://user-images.githubusercontent.com/31080003/183241085-97cd2806-d597-413e-9d17-01a15fdf0822.mp4

@rp1231
Copy link

rp1231 commented Aug 6, 2022

For me, the titlebar actions stop working completely when I enable the option.
(The hand cursor also stops showing)
And everything becomes laggy.

@RamonUnch
Copy link
Owner Author

Well obviously I will need to test with Win10 as I still cannot reproduce.
My guess is that win10 detects specifically when a click is generated while the mouse click is still down and must process multi-touch events, which takes time and can mess up input queue.

@RamonUnch
Copy link
Owner Author

Well I tried a different strategy:
You no longer have this click stuff but I send the Alt key instead.
Of course to prevent Alt from selecting a menu, I have to send Ctrl in between alt down and alt up.

In the [Advanced] section of the .ini file


DragSendsAltCtrl=1
; If set to 1, then Alt_Down, Ctrl_Down, Ctrl_Up, Alt_Up will be sent.
; at the begining of a move/resize action, unless Alt is alreadt down.
; This can help to pop down context menu when the drag starts.

hooks1.55test10_x64.zip
hooks1.55test10_i386.zip

@rp1231
Copy link

rp1231 commented Aug 6, 2022

Yes this works perfectly!
But just out of curiosity why is ctrl also being sent along with alt?
Isn't alt enough?

Also unrelated to all of this.
Why is the titlebar exclusion list called MMBLower?
I always seemed to expand the MMB part as middle mouse button in my head for some reason.

@Ichisich
Copy link

Ichisich commented Aug 6, 2022

@rp1231
Alt alone would trigger menu bars and hotkey overlays.

@RamonUnch
DragSendsAltCtr

-Pro
Far less delay (but still an almost unnoticeable amount).
No interference with MoveUp.

-Contra
Only works on Windows system menus (and ribbon menus) but not on menus which rely solely on focus loss.
In case the Win button is the hotkey button, using zones activates "Shift+Ctrl+Win+Alt" which triggers the office home page (windows quirk 😒).

@RamonUnch
Copy link
Owner Author

But just out of curiosity why is ctrl also being sent along with alt?
Isn't alt enough?

Alt is enough but if you press Alt, then the menu bar will be selected. If you press the alt-ctrl cequence then you fix this problem.

Why is the titlebar exclusion list called MMBLower?
I always seemed to expand the MMB part as middle mouse button in my head for some reason.

It is for backward compatibility with ini file. It used to be only the middle mouse button in the titlebar that would have lowered a window, then I generalized that and did not change the name of the blacklist because it would force everyone to update their .ini file.

@RamonUnch
Copy link
Owner Author

In case the Win button is the hotkey button, using zones activates "Shift+Ctrl+Win+Alt" which triggers the office home page (windows quirk

I will avoid to send the sequence then if Shift is down. however I do not expect it to be perfect, we are starting to send too many keys and shortcuts are triggered more easily.

@rp1231

This comment was marked as off-topic.

@RamonUnch

This comment was marked as off-topic.

@RamonUnch

This comment was marked as off-topic.

@rp1231

This comment was marked as off-topic.

@RamonUnch

This comment was marked as off-topic.

@RamonUnch

This comment was marked as off-topic.

@rp1231
Copy link

rp1231 commented Aug 6, 2022

Thanks

@Ichisich
Copy link

Ichisich commented Aug 6, 2022

Smarter Aero Snap dimensions + ResizeUp=SideSnap
3n1ule

@rp1231
Copy link

rp1231 commented Aug 6, 2022

I'll give ultra instinct a try XD

@RamonUnch
Copy link
Owner Author

Maybe this one will no longer have a lag when using DragSendsAltCtrl=1

hooks1.55test17_x64.zip
hooks1.55test17_i386.zip

@Ichisich
Copy link

Ichisich commented Aug 8, 2022

No perceivable delay whatsoever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants