Slow sync func

[lk2322]

This func block the entire thread for a couple of seconds. Maybe run it in loop.run_in_executor?

DingoLingo/musicbot/audiocontroller.py

Line 261 in 270e750

def search_youtube(self, title):

[lk2322]

We can use decorator like this

from functools import wraps, partial
import asyncio

def run_async(func):
    @wraps(func)
    async def run(*args, loop=None, executor=None, **kwargs):
        if loop is None:
            loop = asyncio.get_event_loop()
        pfunc = partial(func, *args, **kwargs)
        return await loop.run_in_executor(executor, pfunc)

    return run

[Raptor123471]

Can you provide an example? I have tried using a similar method but it does not work.

[lk2322]

If I didn't forget something, I just used this decorator and added await before search_youtube

[malikmajai]

Did we found a solution to this issue that we can apply?

[malikmajai]

If I didn't forget something, I just used this decorator and added await before search_youtube

?

[RafaelSolVargas]

If I didn't forget something, I just used this decorator and added await before search_youtube

Well, i tried to do that, the main problem in that it's not that simple. To be more specific, the preload function that uses asyncio to run multiple tasks at once doesn't support running coroutine or awaitable functions, and as you can see, the search_youtube funct is within the func down, forcing the def down to be a coroutine (so that he can use await search_youtube).

DingoLingo/musicbot/audiocontroller.py

Lines 237 to 245 in 6790bbb

	async def preload(self, song):
	if song.info.title != None:
	return
	def down(song):
	if song.host == linkutils.Sites.Spotify:
	song.info.webpage_url = self.search_youtube(song.info.title)

This information was collected in this stackoverflow: https://stackoverflow.com/questions/46074841/why-coroutines-cannot-be-used-with-run-in-executor
I tried creating two search_youtube functions, one sync and one async, but other bugs were showing up and crashing the bot, so I gave up.

The solution to execute multiple coroutine functions at once is also in the stackoverflow, it's the second answer, but it's not simple and will require some major changes in the logic that interact with YoutubeDL.

https://github.com/RafaelSolVargas/Vulkan/blob/2dbc6c3984b2024ee14502b8b8cd8fd06c967f75/Music/Downloader.py#L108-L124
This is how another discord music bot deal with that exactly problem, the key here is to have an organized way to work with YoutubeDL, possibly using a class