Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add port argument for rasa interactive #4709

Closed
3 tasks
erohmensing opened this issue Nov 1, 2019 · 5 comments · Fixed by #5837
Closed
3 tasks

add port argument for rasa interactive #4709

erohmensing opened this issue Nov 1, 2019 · 5 comments · Fixed by #5837
Assignees
Labels
difficulty:easy 🦋 type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR

Comments

@erohmensing
Copy link
Contributor

Description of Problem:
We can currently run a rasa server and a rasa x server on a specified port instead of the default, but there is no option to do this for rasa interactive. https://forum.rasa.com/t/how-to-run-rasa-interactive-in-a-different-port/10517/6

Overview of the Solution:

  • Add a -p, --port argument to rasa interactive
  • Serve the application on the port if given, or on the DEFAULT_SERVER_PORT if the argument is not passed (where it currently runs)

Definition of Done:

  • Argument is added
  • Functionality with and without -p argument defined manually tested
  • Feature mentioned in the changelog
@erohmensing erohmensing added the type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR label Nov 1, 2019
@pnandhini11
Copy link
Contributor

Hi, I am interested to take up this issue and work on it. Pls let me know.

@erohmensing
Copy link
Contributor Author

Awesome @pnandhini11! I'll assign you to the issue. Let me know if you need any help :) Do you know how to open a PR against our repository in general?

@pnandhini11
Copy link
Contributor

pnandhini11 commented Nov 23, 2019

Hi @erohmensing , I made the necessary changes(in my local) to change the parser arguments to accept port from command line prompt for interactive learning. Can you tell me how to submit the code changes for your review?

@pnandhini11
Copy link
Contributor

Awesome @pnandhini11! I'll assign you to the issue. Let me know if you need any help :) Do you know how to open a PR against our repository in general?

Hi @erohmensing , Can you help me to open PR against our repository?

@erohmensing
Copy link
Contributor Author

Sure thing! Here is our tutorial for making code contributions, let me know if you have any specific questions regarding it: https://forum.rasa.com/t/how-to-make-a-code-contribution-to-rasa/11291

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty:easy 🦋 type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR
Projects
None yet
4 participants