Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rasa cli have an option to turn off colors #9757

Closed
hsm207 opened this issue Sep 30, 2021 · 4 comments
Closed

Make rasa cli have an option to turn off colors #9757

hsm207 opened this issue Sep 30, 2021 · 4 comments
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR

Comments

@hsm207
Copy link
Contributor

hsm207 commented Sep 30, 2021

What problem are you trying to solve?

I want to ran rasa data validate in my pipeline and print the results as a comment in a PR. I save the results in a file like this:

rasa data validate --quiet 2>&1 | tee data-validate.log

The problem is that the ANSI code are saved as part of the output and it makes the results hard to read.

The workaround is to do this:

rasa data validate --quiet 2>&1 | tee data-validate.log |
sed 's/\x1b[[0-9;]*m//g' >
data-validate-no-color.log

What's your suggested solution?

rasa data validate --no-colors

Examples (if relevant)

No response

Is anything blocking this from being implemented? (if relevant)

No

Definition of Done

data-validate.log from rasa data validate --no-colors --quiet 2>&1 | tee data-validate.log does not have ANSI color code.

@hsm207 hsm207 added type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Sep 30, 2021
@rasabot-exalate rasabot-exalate added area:rasa-oss and removed type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Mar 15, 2022 — with Exalate Issue Sync
@rasabot rasabot added area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR and removed area:rasa-oss labels Mar 16, 2022
@rasabot-exalate rasabot-exalate added area:rasa-oss area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR and removed type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss labels Mar 17, 2022 — with Exalate Issue Sync
@thiagohdaqw
Copy link
Contributor

Hi there
Is this still relevant? I think i can work on it

@virtualroot
Copy link
Contributor

Please consider using NO_COLOR envvar.

https://no-color.org/

@thiagohdaqw
Copy link
Contributor

This is a good name for an envvar. It is also used in coloredlogs to disable colors. Thanks, @virtualroot!

https://coloredlogs.readthedocs.io/en/latest/api.html?highlight=no_color#environment-variables

@sync-by-unito
Copy link

sync-by-unito bot commented Dec 19, 2022

➤ Maxime Verger commented:

💡 Heads up! We're moving issues to Jira: https://rasa-open-source.atlassian.net/browse/OSS.

From now on, this Jira board is the place where you can browse (without an account) and create issues (you'll need a free Jira account for that). This GitHub issue has already been migrated to Jira and will be closed on January 9th, 2023. Do not forget to subscribe to the corresponding Jira issue!

➡️ More information in the forum: https://forum.rasa.com/t/migration-of-rasa-oss-issues-to-jira/56569.

@m-vdb m-vdb closed this as completed Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR
Projects
None yet
Development

No branches or pull requests

6 participants