Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Story structure validation tool #4968

Merged
merged 236 commits into from
Feb 25, 2020
Merged

Story structure validation tool #4968

merged 236 commits into from
Feb 25, 2020

Conversation

JEM-Mosig
Copy link
Contributor

@JEM-Mosig JEM-Mosig commented Dec 13, 2019

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@JEM-Mosig JEM-Mosig requested a review from wochinge February 17, 2020 13:13
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wochinge It occurred to me that we could use the length of the longest dialogue in the training data as default for max_history. This makes all the warnings and checks unnecessary 🚀

Great idea, @JEM-Mosig . Looks really good now. Let's discuss the comments, merge in master and then get it into next weeks release!

rasa/core/training/story_conflict.py Outdated Show resolved Hide resolved
rasa/core/validator.py Show resolved Hide resolved
tests/core/test_story_conflict.py Outdated Show resolved Hide resolved


@pytest.fixture
def run_in_default_project_with_info(testdir: Testdir) -> Callable[..., RunResult]:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should not use this at all since it trains a model and this makes our CI slow. You can do it the same way as here https://github.com/RasaHQ/rasa/pull/5243/files#diff-86687b69c02e3fbdf8fcc98e3b4ab350R163 + also use the caplog fixture for the log level https://docs.pytest.org/en/latest/logging.html#caplog-fixture

rasa/cli/data.py Outdated Show resolved Hide resolved
@tmbo
Copy link
Member

tmbo commented Feb 18, 2020

please squash before merge (don't think having 200 commits for this makes sense 😅 )

@tmbo tmbo removed this from the Rasa 1.7 milestone Feb 18, 2020
@degiz degiz added this to the Rasa 1.8 milestone Feb 20, 2020
@JEM-Mosig JEM-Mosig merged commit 730fd06 into master Feb 25, 2020
@JEM-Mosig JEM-Mosig deleted the johannes-4088b branch February 25, 2020 06:58
indam23 pushed a commit that referenced this pull request Jul 27, 2022
Implement the functionality under `rasa data validate stories`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Story structure analysis
5 participants