-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Story structure validation tool #4968
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wochinge It occurred to me that we could use the length of the longest dialogue in the training data as default for max_history. This makes all the warnings and checks unnecessary 🚀
Great idea, @JEM-Mosig . Looks really good now. Let's discuss the comments, merge in master and then get it into next weeks release!
tests/cli/conftest.py
Outdated
|
||
|
||
@pytest.fixture | ||
def run_in_default_project_with_info(testdir: Testdir) -> Callable[..., RunResult]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should not use this at all since it trains a model and this makes our CI slow. You can do it the same way as here https://github.com/RasaHQ/rasa/pull/5243/files#diff-86687b69c02e3fbdf8fcc98e3b4ab350R163 + also use the caplog fixture for the log level https://docs.pytest.org/en/latest/logging.html#caplog-fixture
please squash before merge (don't think having 200 commits for this makes sense 😅 ) |
Implement the functionality under `rasa data validate stories`
Proposed changes:
rasa data validate stories
Status (please check what you already did):
black
(please check Readme for instructions)