Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed unused continue training #4991

Merged
merged 1 commit into from
Feb 20, 2020
Merged

removed unused continue training #4991

merged 1 commit into from
Feb 20, 2020

Conversation

tmbo
Copy link
Member

@tmbo tmbo commented Dec 18, 2019

Proposed changes:

  • removed previously deprecated continue training deprecated continue training #4990
  • removed dump_flattened_stories from Agent.persist
  • improves memory footprint as the trained agent does not keep a reference to all training trackers as part of the ensemble anymore.

Status (please check what you already did):

  • removed some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@tmbo
Copy link
Member Author

tmbo commented Dec 18, 2019

should be merged only after 1.6 has been released.

@tmbo tmbo requested a review from Ghostvv December 18, 2019 11:22
@degiz degiz added this to the Rasa 1.8 milestone Feb 20, 2020
@tmbo tmbo force-pushed the remove-continue-training-completely branch 2 times, most recently from 6b3a5d9 to 8e15ae8 Compare February 20, 2020 14:14
@tmbo tmbo force-pushed the remove-continue-training-completely branch from 8e15ae8 to 38e2638 Compare February 20, 2020 15:50
@tmbo tmbo merged commit 211cb00 into master Feb 20, 2020
@tmbo tmbo deleted the remove-continue-training-completely branch February 20, 2020 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ghostvv Ghostvv Ghostvv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Rasa 1.8
Development

Successfully merging this pull request may close these issues.
3 participants
@tmbo @Ghostvv @degiz