Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in sparse featurizers #5172

Merged
merged 4 commits into from
Feb 3, 2020
Merged

Fix bug in sparse featurizers #5172

merged 4 commits into from
Feb 3, 2020

Conversation

tabergma
Copy link
Contributor

@tabergma tabergma commented Feb 3, 2020

Proposed changes:
When training a Rasa model that contains responses for just some of the intents, training was failing.
Fixed CountVectorsFeaturizer to return a consistent feature vector in case no response was given for a specific message.

closes #5171

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@tabergma tabergma requested a review from dakshvar22 February 3, 2020 09:19
@tabergma tabergma requested a review from dakshvar22 February 3, 2020 10:06
Copy link
Contributor

@dakshvar22 dakshvar22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

@tabergma tabergma merged commit 5837135 into 1.7.x Feb 3, 2020
@tabergma tabergma deleted the bug-sparse-features branch February 3, 2020 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants