Bug nlu comparison nlg responses rebase #5280
Conversation
|
Due to the mess that ensued when trying to get #5202 up to date with 1.7.x to handle dependency issues in travis, this PR replaces that one |
| @@ -0,0 +1,132 @@ | |||
| ## intent:affirm | |||
There was a problem hiding this comment.
do we really need to add a new example? does none of the existing ones work?
| @@ -0,0 +1,9 @@ | |||
| Fix bug encountering: | |||
There was a problem hiding this comment.
This will mess with the log rendering, the first line should be short. e.g.
Fixed incorrectly raised Error encountered in pipelines with a ``ResponseSelector`` and NLG.
...
| @@ -0,0 +1,7 @@ | |||
| ## out of scope non english | |||
There was a problem hiding this comment.
same, I am sure we already have an example like this
| @@ -734,6 +738,15 @@ def test_nlu_comparison(tmpdir): | |||
| run_1_path = os.path.join(output, "run_1") | |||
| assert set(os.listdir(run_1_path)) == {"50%_exclusion", "80%_exclusion", "test.md"} | |||
|
|
|||
| exclude_50_path = os.path.join(run_1_path, "50%_exclusion") | |||
| modelnames = [os.path.basename(c)[:-4] for c in configs] | |||
There was a problem hiding this comment.
| modelnames = [os.path.basename(c)[:-4] for c in configs] | |
| modelnames = [os.path.splitext(os.path.basename(config))[0] for config in configs] |
|
Mhm did I miss something or is there no fix included for the error? as far as I can see you only changed test files |
|
@tmbo I must have left something out during the rebase-cherry pick. I need to move this to 1.8 anyway so will try again. sorry for the confusion. |
|
Should have been rebased on master |
|
@tmbo I've made the changes requested on the other PR - sorry for missing these when I made that one. |
Proposed changes:
Status (please check what you already did):
black(please check Readme for instructions)